Don't send the whole JS module for static FEN display
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Wugapodes
	Sep 27 2021, 12:19 AM

Description

The <fen></fen> tags don't use javascript to display content, and they don't use all of the CSS that <pgn></pgn> tags use. The code currently sends the whole JS and CSS module used by the PGN even when just the FEN position is needed.

Modularize the resources modules into
- CSS for board display
- CSS for Metadata, game notation, and buttons
- JS for board animation
Modify code to send smallest module component needed to display page content
- Revise extension.json to list the javascript and css modules from above
- Edit <fen> rendering to set a trigger different from ChessViewerTrigger used by <pgn>
- Edit ChessBrowserHooks::onOutputPageParserOutput to determine what modules should be sent based on triggers set and send them

Details

	Subject	Repo	Branch	Lines +/-
	Only deliver CSS module for FEN	mediawiki/extensions/ChessBrowser	master	+119 -83

Customize query in gerrit

Related Objects

Mentioned In: rECHB134524367822: Only deliver CSS module for FEN

Event Timeline

Wugapodes created this task.Sep 27 2021, 12:19 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2021, 12:19 AM

TheDJ claimed this task.Sep 28 2021, 9:22 AM

TheDJ moved this task from Needs triage to In Progress on the ChessBrowser board.

Change 724510 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/ChessBrowser@master] Only deliver CSS module for FEN

https://gerrit.wikimedia.org/r/724510

gerritbot added a project: Patch-For-Review.Sep 28 2021, 9:09 PM

I don't think its needed to split the CSS styles module. Technically yes, they are somewhat separate, but the amount of additional CSS is not insane and more important won't be included on many pages. Compare that to the fact that modules are actually expensive (every module name is shipped to every single page).

We could split the files of course. Just for developer ease...

Change 724510 merged by jenkins-bot:

[mediawiki/extensions/ChessBrowser@master] Only deliver CSS module for FEN

https://gerrit.wikimedia.org/r/724510

TheDJ mentioned this in rECHB134524367822: Only deliver CSS module for FEN.Oct 2 2021, 12:08 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2021, 12:10 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 2 2021, 1:00 AM

TheDJ closed this task as Resolved.Oct 2 2021, 11:02 AM

TheDJ moved this task from In Progress to Completed on the ChessBrowser board.