Page MenuHomePhabricator
Create Task
Maniphest T293202

Insert template dialog is sometimes a dead-end in narrow mode
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The dialog opens like this, providing no way to type a template name:

image.png (402×500 px, 18 KB)

This might only happen if the user has already opened the dialog for another template and clicked “show options”. Bug seems to be that we “remember” whether the sidebar was active.

What should happen instead:

image.png (410×503 px, 40 KB)

Details

SubjectRepoBranchLines +/-
Fix rebase mistake in TransclusionDialog classmediawiki/extensions/VisualEditormaster+1 -1
Auto hide the sidebar when only a single placeholder is present in narrow modemediawiki/extensions/VisualEditormaster+6 -6
Customize query in gerrit

Event Timeline

awight created this task.Oct 13 2021, 10:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 10:25 AM
awight triaged this task as Medium priority.Oct 13 2021, 10:36 AM
lilients_WMDE set the point value for this task to 3.Oct 13 2021, 1:06 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-10-13 board.Oct 13 2021, 1:48 PM
Lena_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Oct 13 2021, 1:56 PM
Andrew-WMDE claimed this task.Oct 13 2021, 2:22 PM
gerritbot added a comment.Oct 13 2021, 3:41 PM

Change 730562 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Auto hide the sidebar when only a single placeholder is present in narrow mode

https://gerrit.wikimedia.org/r/730562

gerritbot added a project: Patch-For-Review.Oct 13 2021, 3:41 PM
Andrew-WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2021-10-13 board.Oct 14 2021, 9:04 AM
awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2021-10-13 board.Oct 15 2021, 7:50 AM
gerritbot added a comment.Oct 15 2021, 8:13 AM

Change 730562 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Auto hide the sidebar when only a single placeholder is present in narrow mode

https://gerrit.wikimedia.org/r/730562

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 15 2021, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2021, 9:10 AM
awight closed this task as Resolved.Oct 26 2021, 8:34 AM
awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-10-13 board.
gerritbot added a comment.Oct 26 2021, 8:35 AM

Change 734566 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix rebase mistake in TransclusionDialog class

https://gerrit.wikimedia.org/r/734566

gerritbot added a project: Patch-For-Review.Oct 26 2021, 8:35 AM
gerritbot added a comment.Oct 26 2021, 9:34 AM

Change 734566 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix rebase mistake in TransclusionDialog class

https://gerrit.wikimedia.org/r/734566

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.7; 2021-11-02); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 26 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 26 2021, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits