Page MenuHomePhabricator

mwcli fresh environment variables are gone suddenly
Closed, ResolvedPublicBUG REPORT

Description

I don't know why and when this started to happen to me exactly. Those were there maybe 2 days ago.

$ mwdev dev mw fresh printenv
Going to remove mwcli-mwdd-default_mediawiki-fresh_1
Removing mwcli-mwdd-default_mediawiki-fresh_1 ... done
Creating mwcli-mwdd-default_mediawiki-fresh_1 ... done
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=4042ce95a52f
TERM=xterm
LC_ALL=C.UTF-8
XDG_CACHE_HOME=/cache
XDG_CONFIG_HOME=/tmp/xdg-config-home
NODE_VERSION=v14.17.5-linux-x64
NPM_CONFIG_cache=/cache
BABEL_CACHE_PATH=/cache/babel-cache.json
SPAWN_WRAP_SHIM_ROOT=/tmp/xdg-config-home
NPM_CONFIG_update_notifier=false
CHROMIUM_FLAGS=--no-sandbox
CHROME_BIN=/usr/bin/chromium
FIREFOX_BIN=/usr/local/bin/firefox
HOME=/

$ docker-compose version
docker-compose version 1.29.2, build 5becea4c
docker-py version: 5.0.0
CPython version: 3.7.10
OpenSSL version: OpenSSL 1.1.0l  10 Sep 2019

$ mwdev version -v 2
mw version latest ( 2021-10-23T15:05:29Z )
https://gitlab.wikimedia.org/releng/cli/-/releases
GitCommit: 5e503f3
GitBranch: main
GitState: clean
GitSummary: v0.6.0-8-g5e503f3
BuildDate: 2021-10-23T15:05:29Z
Version: latest

Because of this, even a simple test fails.

$ mwdev dev mw fresh npm run selenium-test -- -- --spec /tests/selenium/specs/page.js

...
[0-0] Error in "Page."before all" hook for "should be previewable""
Error: connect ECONNREFUSED 127.0.0.1:8080
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1148:16)
...

I've tried mwdev dev destroy, rm -rf $(mwdev dev where), docker container prune -f, docker image prune -f and docker image rm docker-registry.wikimedia.org/releng/node14-test-browser:0.0.2, but the problem is still same.

cat $(mwdev dev where)/mediawiki-fresh.yml looks fine to me.

What am I missing?

Event Timeline

Broken in https://gitlab.wikimedia.org/releng/cli/commit/1a1e09ad8bc2edc482f032fb80737ee5382abb10

Which supports users passing env vars, but for both quibble and fresh right now this will override the variables that are part of the docker-compose file :/

should be fixed in main now
Thanks for the report!

I've just tried the last commit and it works, thank you!