OSD: Original image gets removed when layout gets toggled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Soda
	Nov 21 2021, 2:43 PM

Description

When the layout gets toggled, the original hidden image (inside the prp-page-image div) is overwritten. If any script wants to retrieve data on which image was loaded, they need to use internal Openseadragon APIs (namely mw.proofreadpage.viewer.tileSources) to retrieve the image URLs.

Details

	Subject	Repo	Branch	Lines +/-
	OSD: Prevent original image from getting overwritten by OSD	mediawiki/extensions/ProofreadPage	master	+9 -10

Customize query in gerrit

Event Timeline

Soda created this task.Nov 21 2021, 2:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2021, 2:43 PM

Soda claimed this task.Nov 21 2021, 3:09 PM

Change 740334 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/ProofreadPage@master] OSD: Prevent original image from getting overwritten by OSD

https://gerrit.wikimedia.org/r/740334

gerritbot added a project: Patch-For-Review.Nov 21 2021, 3:21 PM

Change 740334 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] OSD: Prevent original image from getting overwritten by OSD

https://gerrit.wikimedia.org/r/740334

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 21 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2021, 8:10 PM

Inductiveload moved this task from Backlog to Done: to deploy/check on the ProofreadPage board.Nov 21 2021, 8:15 PM

This has been changed.

Also, since then, it's now also possible to access the URL properly with mw.config.get( 'prpImageThumbnail' )

OSD: Original image gets removed when layout gets toggledClosed, ResolvedPublicActions

Description

Details

Event Timeline

OSD: Original image gets removed when layout gets toggled
Closed, ResolvedPublic
Actions