Page MenuHomePhabricator

Zooming page images not working on some proofread pages on de.wikisource (lacks srcset attribute)
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • go to https://de.wikisource.org/, then some (random) page in the page namespace
  • edit page
  • try to zoom in page images / try to move page image in the viewer with mouse (on desktop) or touch (on phone)

What happens?:
Since Nov. 22nd, on some pages the images can't be zoomed or moved, some random examples :
https://de.wikisource.org/wiki/Seite:Constitution_der_europaeischen_staaten_324.jpg
https://de.wikisource.org/wiki/Seite:Dante_Prosa_014.gif
https://de.wikisource.org/wiki/Seite:De_Fechtbuch_Talhoffer_148.jpg
https://de.wikisource.org/wiki/Seite:Historisch-antiquarische_Untersuchungen_262.png
https://de.wikisource.org/wiki/Seite:Meyers_b11_s1011.jpg

on other pages (but from other books) it works fine, example:
https://de.wikisource.org/wiki/Seite:Lucians_Werke_0108.jpg

What should have happened instead?:
Zooming and moving should work as before :)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
used: Vivaldi browser on Windows 7 (both, logged in and logged out of my account)
also: DuckDuckGo app on mobile phone (logged out)

Event Timeline

Right, well I know why the JS breaks: the broken images do not have a srcset attribute.

Change 740771 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/extensions/ProofreadPage@master] OSD: Handle cases where the image srcset attr is not set

https://gerrit.wikimedia.org/r/740771

Change 740784 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.9] OSD: Handle cases where the image srcset attr is not set

https://gerrit.wikimedia.org/r/740784

Change 740771 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] OSD: Handle cases where the image srcset attr is not set

https://gerrit.wikimedia.org/r/740771

Aklapper renamed this task from Zooming page images not working on some proofread pages on de.wikisource to Zooming page images not working on some proofread pages on de.wikisource (lacks srcset attribute).Tue, Nov 23, 10:09 AM

Change 740784 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.9] OSD: Handle cases where the image srcset attr is not set

https://gerrit.wikimedia.org/r/740784

Mentioned in SAL (#wikimedia-operations) [2021-11-23T12:29:09Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.9/extensions/ProofreadPage/modules/page/ext.proofreadpage.page.edit.js: Backport: [[gerrit:740784|OSD: Handle cases where the image srcset attr is not set (T296260)]] (duration: 00m 56s)

This has now been deployed to Wikisources: @Mapmarks can you please confirm?

@Inductiveload Yes, it seems that zooming works again on all pages. Thank you all! Nice work!

Inductiveload claimed this task.