Page MenuHomePhabricator
Create Task
Maniphest T297728

[Maintenance] Update Vector to use html-title-heading template variable.
Closed, ResolvedPublicBUG REPORT
Actions

Description

In T255682 the heading logic was centralized to core.
The html-title-heading template variable was added to create the h1 markup for the primary heading in the page. In future this will allow us to consistently identify headings across skins (currently Minerva uses the non-standard section_0 ID for example.

We should use this inside Vector rather than html-title for the primary heading in the page.

Details

SubjectRepoBranchLines +/-
Vector uses html-title-headingmediawiki/skins/Vectormaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Dec 14 2021, 5:45 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptDec 14 2021, 5:45 PM
Jdlrobson triaged this task as Medium priority.Dec 14 2021, 5:45 PM
Jdlrobson added projects: Web-Team-Backlog (Needs Prioritization (Tech)), MediaWiki-Core-Skin-Architecture.
gerritbot added a comment.Dec 14 2021, 5:46 PM

Change 747176 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Vector uses html-title-heading

https://gerrit.wikimedia.org/r/747176

gerritbot added a project: Patch-For-Review.Dec 14 2021, 5:47 PM
Jdlrobson moved this task from Backlog to Vector code cleanup on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Dec 14 2021, 6:57 PM
Jdlrobson moved this task from Backlog to Small HTML modifications to support our users better on the MediaWiki-Core-Skin-Architecture board.
gerritbot added a comment.Dec 15 2021, 10:57 PM

Change 747176 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Vector uses html-title-heading

https://gerrit.wikimedia.org/r/747176

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 15 2021, 11:00 PM
Jdlrobson closed this task as Resolved.Dec 15 2021, 11:01 PM
Jdlrobson claimed this task.
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).

I've made a note to evangelize this week of 3rd.

Maintenance_bot removed a project: Patch-For-Review.Dec 15 2021, 11:10 PM
Jdlrobson mentioned this in T297019: Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector.Dec 22 2021, 1:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits