Page MenuHomePhabricator
Create Task
Maniphest T297951

Web2Cit should reject top-level domains
Closed, InvalidPublic
Actions

Description

Web2Cit works on a per-domain basis. A set of 3 files are defined for each supported domain: templates, tests, and patterns (see Web2Cit Specs).

Given a Target URL, the 3-file set defined for the most-specific subdomain is used. For example, given subdomain.example.com/article, if no set has been defined for subdomain.example.com, the set defined for example.com will be used.

To prevent contributors from defining translation sets for effective top level domains, these should be rejected by the frontend, backend, etc.

Event Timeline

diegodlh created this task.Dec 17 2021, 2:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2021, 2:42 PM
diegodlh renamed this task from Reject top-level domains to Web2Cit should reject top-level domains.Dec 17 2021, 2:42 PM
• BilalShirwani closed this task as a duplicate of T298058: [Impact Analysis] Evaluate Impact of Mobile Reply and New Discussion Tools.Dec 20 2021, 11:57 PM
JJMC89 reopened this task as Open.Dec 21 2021, 12:13 AM
diegodlh closed this task as Invalid.May 19 2022, 8:38 PM

Given a Target URL, the 3-file set defined for the most-specific subdomain is used

This design decision has been overruled. We use configuration files for the specific domain (including subdomains) that the target webpage belongs to.

Closing as invalid.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL