Standardise type for transcode_time_* columns
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Jan 5 2022, 8:26 PM

Description

According to T42626 the timestamp should be adjust from varbinary(14) to binary(14) because there is no need to hold infinite.

Details

	Subject	Repo	Branch	Lines +/-
	abstract schema: Use mwtimestamp type for transcode_time_* columns	mediawiki/extensions/TimedMediaHandler	master	+211 -20

Customize query in gerrit

Related Objects

Mentioned In: T298743: Apply alter for transcode_time_* columns on wmf wikis
Mentioned Here: T157424: TimedMediaHandler does not support PostgreSQL
T42626: Standardise type of timestamp database fields (MySQL)

Event Timeline

Umherirrender created this task.Jan 5 2022, 8:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2022, 8:26 PM

Change 751797 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TimedMediaHandler@master] abstract schema: Use mwtimestamp type for transcode_time_* columns

https://gerrit.wikimedia.org/r/751797

gerritbot added a project: Patch-For-Review.Jan 5 2022, 8:27 PM

After this task gets fixed, the postgres failures from T157424 could be retested
(the schema should be ready for postgres after schema change, but sometimes some queries are not and that needs then more work, which could be tracked on the other task marked for postgres).