Maniphest T298808

check_user - KeyError: 'relations'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dzahn
	Jan 7 2022, 8:14 PM

Tags

Referenced Files

None

Subscribers

Tokens

"Orange Medal" token, awarded by Dzahn.

Description

When using check_user (the script used for https://wikitech.wikimedia.org/wiki/SRE/Clinic_Duty/Access_requests#Verifying_WMF_developer_accounts verifying developer accounts

this can happen:

[cumin1001:~] $ sudo check_user jvargas@wikimedia.org
WikiTech Users:
	Username:	JVargas
	Verified Email:	20220106184544
Traceback (most recent call last):
  File "/usr/local/sbin/check_user", line 182, in <module>
    raise SystemExit(main())
  File "/usr/local/sbin/check_user", line 167, in main
    [r['value'] for r in user['relations'] if r['type'] == 'manager']
KeyError: 'relations'

This was from T298719#7606192 while I had no problem using it at T298766#7606177.

Seems like it errors out if no manager was defined.

Details

	Subject	Repo	Branch	Lines +/-
	check_user: catch manager being None	operations/puppet	production	+7 -4

Customize query in gerrit

Related Objects

Mentioned Here: T298719: Grant Access to <Idap/wmf> for <JVargas>
T298766: Grant Access to ldap/wmf for Marco_Fossati

Event Timeline

Dzahn created this task.Jan 7 2022, 8:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2022, 8:14 PM

Dzahn updated the task description. (Show Details)Jan 7 2022, 8:15 PM

Dzahn updated the task description. (Show Details)

Dzahn added a project: Infrastructure-Foundations.

Change 752018 had a related patch set uploaded (by RhinosF1; author: RhinosF1):

[operations/puppet@production] check_user: catch manager being None

https://gerrit.wikimedia.org/r/752018

gerritbot added a project: Patch-For-Review.Jan 7 2022, 8:33 PM

RhinosF1 added a project: User-RhinosF1.Jan 7 2022, 11:10 PM

Restricted Application added a subscriber: RhinosF1. · View Herald TranscriptJan 7 2022, 11:10 PM

RhinosF1 moved this task from Radar to Deployment on the User-RhinosF1 board.Jan 7 2022, 11:10 PM

Dzahn triaged this task as Medium priority.Jan 7 2022, 11:41 PM

Change 752018 merged by Jbond:

[operations/puppet@production] check_user: catch manager being None

https://gerrit.wikimedia.org/r/752018

Thanks to @jbond for merge.

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2022, 12:10 PM

Dzahn awarded a token.Jan 10 2022, 7:11 PM