Page MenuHomePhabricator

cosmetic_changes_tests.TestCosmeticChangesISBN.test_invalid_isbn() fails
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce:
C:\pwb\GIT\core>pwb cosmetic_changes_tests

What happens?:

C:\pwb\GIT\core>pwb cosmetic_changes_tests
tests: max_retries reduced from 15 to 1
.F......................x.......x
======================================================================
FAIL: test_invalid_isbn (__main__.TestCosmeticChangesISBN)
Test that it'll fail when the ISBN is invalid.
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\tests\cosmetic_changes_tests.py", line 589, in test_invalid_isbn
    with self.assertRaisesRegex(
AssertionError: ValidationError not raised

----------------------------------------------------------------------
Ran 33 tests in 2.284s

FAILED (failures=1, expected failures=2)

C:\pwb\GIT\core>

Software version:
Pywikibot 7.0.0.dev0

Event Timeline

Xqt triaged this task as High priority.Jan 14 2022, 5:58 PM

Change 754008 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Safe self.cct.ignore before tests in test_ignore_invalid_isbn

https://gerrit.wikimedia.org/r/754008

Change 754008 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Safe self.cct.ignore before tests in test_ignore_invalid_isbn

https://gerrit.wikimedia.org/r/754008