Page MenuHomePhabricator

namespaceDupes.php does not fix pages with space/underscore between namespace and colon
Open, Needs TriagePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • An error was thrown as part of T293291 for an invalid title
  • The error happens on a title starting with a namespace followed by underscore and colon. The namespace was added T214553 and namespaceDupes.php was running on that task, but the wrong titles are not shown in the listing from that maintenance script.

What happens?:
namespaceDupes.php does not fix pages with namespace + underscore + colon (it only checks namespace + colon):

MariaDB [sawikisource_p]> select page_id, page_namespace, page_title from page where page_title like '%लेखक%';
+---------+----------------+----------------------------------------------------------------------------------------------------------+
| page_id | page_namespace | page_title                                                                                               |
+---------+----------------+----------------------------------------------------------------------------------------------------------+
|   64624 |              0 | लेखकः_:अज्ञातलेखकः                                                                                       |
|   36882 |              0 | लेखकः_:अप्पय्यदीक्षित                                                                                    |
|   36877 |              0 | लेखकः_:उपमन्यु                                                                                           |
|   78583 |              0 | लेखकः_:कालिदासः                                                                                          |
|   47306 |              0 | लेखकः_:क्षेमेन्द्रः                                                                                      |
|   42881 |              0 | लेखकः_:गर्गमुनि                                                                                          |
|   32074 |              0 | लेखकः_:गर्गमुनिः                                                                                         |
|   79245 |              0 | लेखकः_:तारानाथ_भट्टाचार्य                                                                                |
|   36887 |              0 | लेखकः_:त्यागराजनाम्ना                                                                                    |
|   78606 |              0 | लेखकः_:दण्डिनः                                                                                           |
|   60157 |              0 | लेखकः_:दण्डी                                                                                             |
|   36885 |              0 | लेखकः_:नीलकण्ठ_दीक्षित                                                                                   |
|    8935 |              0 | लेखकः_:भरतमुनिः                                                                                          |
|   36421 |              0 | लेखकः_:भासः                                                                                              |
|   40874 |              0 | लेखकः_:रावण                                                                                              |
|   65822 |              0 | लेखकः_:वागाम्भृणी                                                                                        |
|   45207 |              0 | लेखकः_:वाल्मीकिः                                                                                         |
|   64551 |              0 | लेखकः_:वेदव्यासः                                                                                         |
|   36875 |              0 | लेखकः_:शंकरभगवतः                                                                                         |
|   42635 |              0 | लेखकः_:श्रीशिवाभिनवनृसिंहभारतीस्वामि                                                                     |
|   36874 |              0 | लेखकः_:स्वामी_विवेकानन्द                                                                                 |
|   89849 |              0 | लेखकःशूद्रकः                                                                                             |
+---------+----------------+----------------------------------------------------------------------------------------------------------+
22 rows in set (0.11 sec)

What should have happened instead?:
namespaceDupes.php should find all possible invalid title cases on the database and fix them. Title::makeTitleSafe could fix this extra space and the namespace issue and the script could move the page.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.: master