Page MenuHomePhabricator

Experiment with adding more context to list and tool revision history
Closed, ResolvedPublic

Description

Right now both list and tools revision history looks somewhat like this:

current_list_review_look.PNG (587×1 px, 96 KB)

while the audit history looks like this:

audit_log.PNG (685×984 px, 81 KB)

You will notice that the list and tools revision history has less context than the audit history (the only source of description in a revision history is the revision comment, and that alone is not sufficient source since the person providing the context can add a confusing comment). The audit history tells the story of what is happening at a glance.
This was ok in the past because the list and tools revision history views as we currently have them are in either a list or tools details view, so there is the implicit context of what tool and list the revision belongs to.

If we create a unified revision history view however, it will be very difficult to decide what tool or list a particular revision belongs too.
The tools and list revision history view needs to look less like it looks now and more like the audit history view.

Event Timeline

The easiest way to do this is to create a RecentChangesSerializer and along with every other field in our standard revision history serializer, add a derived field that indicates whether it's a "created" change or an "edited" changes along with another derived field to help indicate if we are dealing with a list or a tool revision. These two information can be used on the frontend to add more context to revision history cards.

Change 767256 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[wikimedia/toolhub@main] api: create endpoint for recent revision changes for a more unified patrolling workflow

https://gerrit.wikimedia.org/r/767256

Change 767256 merged by jenkins-bot:

[wikimedia/toolhub@main] api: add /api/recent/ endpoints for patrolling

https://gerrit.wikimedia.org/r/767256

Change 786342 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-04-21-215651-production

https://gerrit.wikimedia.org/r/786342

Change 786342 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: Bump container version to 2022-04-21-215651-production

https://gerrit.wikimedia.org/r/786342