Page MenuHomePhabricator
Create Task
Maniphest T302671

scripts tested by script_tests aren't covered by coverage
Closed, ResolvedPublic
Actions

Description

scripts tested by script_tests aren't covered by coverage.
Appveyour runs tests with coverage and uploads the coverage.xml to codecov.io. But the script folder only contains scripts tested by its own test. script_test does not lead to the script be covered.

Details

SubjectRepoBranchLines +/-
[tests] run pytest on wikipedia:testpywikibot/coremaster+4 -3
[tests] run pytest on wikipedia:testpywikibot/coremaster+5 -1
[tests] Update coverage and pytest-cov requirementspywikibot/coremaster+4 -2
[tests] Upload coverage to Codecovpywikibot/coremaster+3 -0
Customize query in gerrit

Event Timeline

Xqt created this task.Feb 27 2022, 11:22 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptFeb 27 2022, 11:22 AM
Xqt triaged this task as Medium priority.Feb 27 2022, 11:22 AM
Xqt renamed this task from scripts tested by script_tests aren't covered by coverate to scripts tested by script_tests aren't covered by coverage.Feb 27 2022, 3:42 PM
Xqt updated the task description. (Show Details)
Xqt added a comment.Feb 27 2022, 3:50 PM

The code coverage of script_tests was provided previously by travis tests. After merging to github action this fails obviously:
https://codecov.io/api/gh/wikimedia/pywikibot/download/build?path=v4/raw/2020-05-04/216B3D0824E8DF1644111F5EF1757B3F/8367b7828fcda080043a7b689d3f7283903afd30/07ef35ce-4eb2-49a4-86f9-863e1349e146.txt

Xqt claimed this task.Feb 27 2022, 4:04 PM
gerritbot added a comment.Feb 27 2022, 4:21 PM

Change 766309 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Upload coverage to Codecov

https://gerrit.wikimedia.org/r/766309

gerritbot added a project: Patch-For-Review.Feb 27 2022, 4:21 PM

Change 766309 merged by Xqt:

[pywikibot/core@master] [tests] Upload coverage to Codecov

https://gerrit.wikimedia.org/r/766309

Maintenance_bot removed a project: Patch-For-Review.Feb 27 2022, 5:10 PM
gerritbot added a comment.Feb 28 2022, 9:22 AM

Change 766569 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Update coverage and pytest-cov requirements

https://gerrit.wikimedia.org/r/766569

gerritbot added a project: Patch-For-Review.Feb 28 2022, 9:22 AM

Change 766569 merged by Xqt:

[pywikibot/core@master] [tests] Update coverage and pytest-cov requirements

https://gerrit.wikimedia.org/r/766569

gerritbot added a comment.Feb 28 2022, 9:55 AM

Change 766583 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] run pytest on wikipedia:test

https://gerrit.wikimedia.org/r/766583

gerritbot added a comment.Feb 28 2022, 9:56 AM

Change 766583 merged by Xqt:

[pywikibot/core@master] [tests] run pytest on wikipedia:test

https://gerrit.wikimedia.org/r/766583

gerritbot added a comment.Feb 28 2022, 10:53 AM

Change 766592 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] run pytest on wikipedia:test

https://gerrit.wikimedia.org/r/766592

gerritbot added a comment.Feb 28 2022, 10:53 AM

Change 766592 merged by Xqt:

[pywikibot/core@master] [tests] run pytest on wikipedia:test

https://gerrit.wikimedia.org/r/766592

Xqt closed this task as Resolved.Feb 28 2022, 11:27 AM

pytest -cov required to get all the scripts covered

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits