Page MenuHomePhabricator

Prepare and check storage layer for shnwikivoyage
Closed, ResolvedPublic

Description

The new wiki's visibility will be: Public.

Event Timeline

LSobanski triaged this task as Medium priority.Mar 1 2022, 1:07 PM
LSobanski moved this task from Triage to Blocked on the DBA board.
LSobanski added a subscriber: LSobanski.

Thanks, let us know when the database is created, so we can sanitize it.

Urbanecm added a subscriber: Urbanecm.

Thanks, let us know when the database is created, so we can sanitize it.

The database was just created.

Marostegui added a subscriber: Marostegui.

Datata sanitized. User and _p database created. I have ran a check_private_data.py just to be fully sure there's no private data there. Also tested creating a new user on the wiki and the triggers work fine too.
This is ready for views creation.

When running the maintain-views script for shnwikivoyage, we received the following warning.

2022-04-26 15:53:24,038 WARNING Too big for this database

Any idea what this means, anyone? It seemed to success in every other way.

When running the maintain-views script for shnwikivoyage, we received the following warning.

2022-04-26 15:53:24,038 WARNING Too big for this database

Any idea what this means, anyone? It seemed to success in every other way.

This seems to be emitted by maintain-views when a view creation is requested and the view's configuration has a database "size" limit that is greater than the current database's size. In practice the only code path I can find that triggers this is the user_properties_anon view. That view has a limit: 2 clause in it's configuration. The 2 here means "medium" sized wikis indicating that the user_properties_anon view should only be created for wikis which appear in medium.dblist or large.dblist.

So... working as expected, but the log message emitted by maintain-views could be improved by changing it from a warning to info level, listing the view name, and having a message that makes more logical sense like:

logging.info(
    "Skipping creation of %s. DB size %d < required %d.",
    view_name,
    self.db_size,
    view_details["limit"],
)

Thanks for the explanation @bd808
So I'm happy that the views have been created on all of the clouddb databases. What else remains to be done for this ticket?

Marostegui claimed this task.

Tested shnwikivoyage_p and looks good. Resolving!

Mentioned in SAL (#wikimedia-operations) [2023-03-29T11:55:16Z] <btullis@cumin1001> Added views for new wiki: shnwikivoyage T302798