| • TrevorParscal | |
| Mar 28 2011, 1:15 AM |
| F7907: yourtext-readonly-patch.diff | |
| Nov 21 2014, 11:36 PM |
| F7906: test_case.txt | |
| Nov 21 2014, 11:36 PM |
When running into an edit conflict, the "your changes" box at the bottom which shows the version you submitted and got rejected is editable, making it easy for users to mistake it for the edit box, copy the conflicted change in and save, only for them to realize their changes were not applied.
If the box is made read-only, this would be far less likely to happen.
Version: unspecified
Severity: trivial
horcheram wrote:
Test case
To create an edit conflict to test for this bug, open a wiki article in one window of the browser. Choose edit for the page and start editing.
Open the same article in another window of the browser. Choose edit for the page and start editing. Hit Save Changes in the second window.
The original window open will trigger an edit conflict.
Attached:
Created attachment 8536
Patch to make "your text" textareas read-only
Patch against r88116. The "Your text" box shows up if $wgSpamRegex is triggered or if a user hits an edit conflict (showTextbox2 function in includes/EditPage.php). In either case, there's no input mechanism, so <textarea readonly=""> makes sense.
Attached: