Page MenuHomePhabricator

Edit conflicts not triggering reliably
Closed, DuplicatePublicBUG REPORT

Description

Initially reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Edit_conflicts, I have replicated the issue as this should have conflicted with this.

List of steps to reproduce (step by step, including full links if applicable):

  • Open a page for editing (e.g. your sandbox) in two separate tabs—
  • Make changes in one tab and save
  • Make different changes in the other tab and save

What happens?:
The second set of edits overwrites the first

What should have happened instead?:
An edit conflict should have been displayed

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

  • I have tried this with Paragraph-based Edit Conflicts enabled and disabled - same behaviour
  • Vector

Event Timeline

TheresNoTime renamed this task from Edit conflicts not triggering to Edit conflicts not triggering reliably.Mar 9 2022, 12:48 PM

nb. may have been a bad issue confirmation, as "Unless they've changed it since I last looked, you can't edit conflict with yourself." [1]

[1] https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&diff=1076115579&oldid=1076115051&diffmode=source

I've reproduced this misbehaviour in a sandbox, which may be invalid as both edits were by the same editor. I've also seen it in the wild with different editors. It's intermittent, but here are two scenarios which may make it more likely.
1: User:A starts editing page X; user:B moves page X to a new title Y, leaving a redirect X→Y; user:A publishes the change. This overwrites redirect X with a copy-paste move of a modified copy of Y.
2: User:A starts editing page X; user:B makes a quick section edit to X#Foo; user:A publishes the whole-page change. User:B's section changes are lost.

Edit conflicts are not supposed to trigger if the only conflict would be with yourself. This is a long-standing (mis)feature, and there are some proposals to change it, but it is the expected behavior for now. See discussion on T175745.

@Certes If both edits are by the same user, then that's the same as above. If you have an example of the bug occurring with two different users, or if you can reproduce it, then please file a task. I've searched for existing reports, and apparently there is a bug where a conflict is not detected when moving without leaving a redirect, which is what you might have seen in the wild: T25044.