Fix navbar issue on screens with smaller height
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Raymond_Ndibe
	Mar 16 2022, 5:13 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

Get a device where the screen height is less than 750px or minimize your browser screen and adjust the screen height to be less than 750px.

What happens?:

What happens is that you get a navbar that looks like the one in the image below:

What should have happened instead?:

The navbar scrolling should look a little bit pleasing to the eye. Right now its not.

Details

	Subject	Repo	Branch	Lines +/-
	toolhub: Bump container version to 2022-05-17-072641-production	operations/deployment-charts	master	+1 -1
	ui: fix issue with navbar scrollbar	wikimedia/toolhub	main	+34 -0

Customize query in gerrit

Related Objects

Mentioned Here: T286860: Sidebar scrollbar should collapse with the sidebar

Event Timeline

Raymond_Ndibe created this task.Mar 16 2022, 5:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2022, 5:13 AM

Seems similar to T286860: Sidebar scrollbar should collapse with the sidebar which I was never able to reproduce.

In T303909#7782213, @bd808 wrote:

Seems similar to T286860: Sidebar scrollbar should collapse with the sidebar which I was never able to reproduce.

I think it's exactly the same bug. It became more of an issue because of the new nav items we added to the navbar.

Wondering if webkit-scrollbar styling can help here.

In T286860#7522007, @bd808 wrote:

I don't know of anything special Toolhub does with the navigation menu that would deviate from the upstream Vuetify library, so it feels that if there is a bug here it is an upstream one. With a reproduction case in hand we might be able to confirm or disprove that this is normal behavior with a v-navigation-drawer and 'below the fold' content in that reproduction case.

bd808 moved this task from Backlog to Groomed/Ready on the Toolhub board.Apr 14 2022, 7:31 PM

bd808 triaged this task as Medium priority.Apr 14 2022, 7:33 PM

Change 781295 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[wikimedia/toolhub@main] ui: fix issue with navbar scrollbar

https://gerrit.wikimedia.org/r/781295

gerritbot added a project: Patch-For-Review.Apr 15 2022, 3:12 AM

Raymond_Ndibe moved this task from Groomed/Ready to Review on the Toolhub board.Apr 15 2022, 3:22 AM

bd808 assigned this task to Raymond_Ndibe.Apr 25 2022, 8:35 PM

Change 781295 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: fix issue with navbar scrollbar

https://gerrit.wikimedia.org/r/781295

Maintenance_bot removed a project: Patch-For-Review.May 17 2022, 7:31 AM

Change 792696 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-05-17-072641-production

https://gerrit.wikimedia.org/r/792696

gerritbot added a project: Patch-For-Review.May 17 2022, 7:07 PM

Change 792696 merged by jenkins-bot: