Page MenuHomePhabricator
Create Task
Maniphest T303970

Deal with Gerrit 3.4 change.mergeabilityComputationBehavior
Closed, ResolvedPublic
Actions

Description

Breaking change from Gerrit 3.4

is:mergeable predicate is disabled per default.

Computing is:mergeable has a O(N^2) runtime computation complexity depending on the number of open changes on a branch and on the size of the changes. Hence skip this computation per default to avoid the associated runtime effort.

Most Gerrit installation already disabled this feature and thus wouldn’t need to change anything. Otherwise, to restore the previous behaviour this option: change.mergeabilityComputationBehavior should be changed to API_REF_UPDATED_AND_CHANGE_REINDEX.

The default is NEVER on Gerrit 3.4

3.3 accepts API_REF_UPDATED_AND_CHANGE_REINDEX

Upstream issue https://bugs.chromium.org/p/gerrit/issues/detail?id=14528

Details

SubjectRepoBranchLines +/-
gerrit: keep computing changes mergeabilityoperations/puppetproduction+4 -0
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Mar 16 2022, 4:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2022, 4:04 PM
hashar mentioned this in T303967: Display mergeable status in scap backport --list output.Mar 16 2022, 4:05 PM
hashar added a comment.Mar 16 2022, 5:07 PM

I think we just have to set it explicitly to API_REF_UPDATED_AND_CHANGE_REINDEX in our gerrit.config. The setting is recognized by Gerrit 3.3 so that can be done before the upgrade.

hashar updated the task description. (Show Details)Apr 27 2022, 3:08 PM
gerritbot added a comment.Apr 27 2022, 3:10 PM

Change 786984 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/puppet@production] gerrit: keep computing changes mergeability

https://gerrit.wikimedia.org/r/786984

gerritbot added a project: Patch-For-Review.Apr 27 2022, 3:10 PM
hashar claimed this task.Apr 27 2022, 3:11 PM
gerritbot added a comment.Apr 27 2022, 4:39 PM

Change 786984 merged by JHathaway:

[operations/puppet@production] gerrit: keep computing changes mergeability

https://gerrit.wikimedia.org/r/786984

hashar closed this task as Resolved.Apr 27 2022, 4:42 PM

change.mergeabilityComputationBehavior has been set to API_REF_UPDATED_AND_CHANGE_REINDEX

A note, our Gerrit 3.3 documentation mentions the default is REF_UPDATED_AND_CHANGE_REINDEX but that is an error in the Documentation. The stable-3.3 source code definitely defaults to API_REF_UPDATED_AND_CHANGE_REINDEX

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2022, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits