Page MenuHomePhabricator
Create Task
Maniphest T305048

Validate test requests against OpenAPI spec in e2e/spec tests
Closed, ResolvedPublic
Actions

Description

This is to make sure that the requests we are generating for testing purposes, are in fact valid according to the OpenAPI spec.

Example, when this is actually useful: We should make make sure that we are sending a comma-separated list of fields in our e2e-test, not a pipe-separated one, because otherwise the test may pass when in fact it should fail according to the spec.

Details

SubjectRepoBranchLines +/-
REST: Extract function for request validationmediawiki/extensions/Wikibasemaster+34 -40
REST: Validate requests in e2e testsmediawiki/extensions/Wikibasemaster+146 -14
Customize query in gerrit

Event Timeline

Silvan_WMDE created this task.Mar 30 2022, 11:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2022, 11:54 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 3) board.Mar 30 2022, 11:54 AM
gerritbot added a comment.Mar 31 2022, 12:53 PM

Change 775853 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Validate requests in e2e tests

https://gerrit.wikimedia.org/r/775853

gerritbot added a project: Patch-For-Review.Mar 31 2022, 12:53 PM
Silvan_WMDE removed Silvan_WMDE as the assignee of this task.Mar 31 2022, 12:59 PM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 3) board.
gerritbot added a comment.Apr 1 2022, 2:39 PM

Change 775853 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate requests in e2e tests

https://gerrit.wikimedia.org/r/775853

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Apr 1 2022, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 1 2022, 3:10 PM
gerritbot added a comment.Apr 1 2022, 3:14 PM

Change 776213 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Extract function for request validation

https://gerrit.wikimedia.org/r/776213

gerritbot added a project: Patch-For-Review.Apr 1 2022, 3:14 PM
gerritbot added a comment.Apr 4 2022, 10:40 AM

Change 776213 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Extract function for request validation

https://gerrit.wikimedia.org/r/776213

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 3) board.Apr 4 2022, 10:42 AM
WMDE-leszek closed this task as Resolved.Apr 19 2022, 9:07 PM
WMDE-leszek claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL