Page MenuHomePhabricator

No image preview in an "uploadable" combobox field
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • create a form with an "uploadable" field (in my case: input type=combobox) with the image preview option
  • then edit a page with this form and fill in a value in the given field (either by uploading an image or by changing the value directly)

What happens?:
Using the field only shows the image if the field was filled in a previous save of the form. The image is not updated if the field value is changed.

What should have happened instead?:
A preview of the image corresponding to the field value should appear below the field.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
MW 1.35.6 / PHP 7.4.27 / MariaDB 10.1.48 / SMW 3.2.3 / PF 5.3.4

Event Timeline

Change 913931 had a related patch set uploaded (by Techwizzie; author: Techwizzie):

[mediawiki/extensions/PageForms@master] Fix image preview problem in uploadable combobox field

https://gerrit.wikimedia.org/r/913931

Yaron_Koren renamed this task from No image preview in an "uploadable" field to No image preview in an "uploadable" combobox field.May 1 2023, 7:33 PM
Yaron_Koren subscribed.

This does seem to affect only the combobox input type.

Change 914443 had a related patch set uploaded (by Yaron Koren; author: Yaron Koren):

[mediawiki/extensions/PageForms@master] Get image preview working again for uploadable comboboxes

https://gerrit.wikimedia.org/r/914443

Change 914443 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Get image preview working again for uploadable comboboxes

https://gerrit.wikimedia.org/r/914443

Change 913931 abandoned by Yaron Koren:

[mediawiki/extensions/PageForms@master] Fix image preview problem in uploadable combobox field

Reason:

This was implemented differently - see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageForms/+/914443

https://gerrit.wikimedia.org/r/913931

Yaron_Koren claimed this task.

@Megajoule - sorry for the long delay. I believe this is fixed now!