Page MenuHomePhabricator

Replace ini config system with envvar config system
Closed, ResolvedPublicFeature

Description

Striker invented its own system for non-executable configuration based on ini files providing values to interpolate into settings.py. This system is interesting, but also novel. https://pypi.org/project/django-environ/ can be used to provide similar functionality with less local magic. As a nice side effect, envvar based configuration is easier to reason about with a container based deployment.

Event Timeline

bd808 triaged this task as High priority.Apr 19 2022, 8:02 PM
bd808 changed the subtype of this task from "Task" to "Feature Request".
bd808 moved this task from Backlog to Doing on the Striker board.

It would actually be nice to have some period of supporting both ini and envvar based config, but it's probably easier from an implementation point of view to jump forward to envvar only.

bd808 changed the task status from Open to In Progress.Apr 20 2022, 12:06 AM

Change 784764 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[labs/striker@master] config: replace ini config with envvars

https://gerrit.wikimedia.org/r/784764

Change 784764 merged by jenkins-bot:

[labs/striker@master] config: replace ini config with envvars

https://gerrit.wikimedia.org/r/784764