Do not call mLinkHolders __destruct explicitly
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	VitaliyFilippov
	Apr 27 2011, 3:50 PM

Description

simple patch

Calling $this->mLinkHolders->__destruct(); explicitly is incorrect because it sometimes leads to strange errors. I can't tell exactly which errors... :) because our wiki distribution (wiki.4intra.net) is patched manually since 1.13 :)
I think you should use unset( $this->mLinkHolders ) and let PHP run the destructor.

Version: unspecified
Severity: normal

Attached:

Y-000-dont-call-linkholders-_destruct.diff559 BDownload

Details

Reference: bz28719

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:27 PM

• bzimport added a project: MediaWiki-General.

• bzimport set Reference to bz28719.

• bzimport added a subscriber: Unknown Object (MLST).

VitaliyFilippov created this task.Apr 27 2011, 3:50 PM

Makes sense to me, we're using unset() beneath that

Thanks

r87039

Do not call mLinkHolders __destruct explicitlyClosed, ResolvedPublicActions

Description

Details

Event Timeline

Do not call mLinkHolders __destruct explicitly
Closed, ResolvedPublic
Actions