Page MenuHomePhabricator
Create Task
Maniphest T307758

Thumbcaption spacing height is off
Closed, ResolvedPublicBUG REPORT
Actions

Description

The height of the spacing above the thumbcaption is slightly higher than intended.
https://ru.wikipedia.org/wiki/Википедия:Форум/Технический#Лишний_зазор_в_видео-миниатюрах

Screenshot 2022-05-06 at 08.39.55.png (632×418 px, 53 KB)

This is because .mw-tmh-player is set to be an inline-block element, because audio/video elements are inline elements so we want this behavior for those outside thumb frames.

Details

SubjectRepoBranchLines +/-
Fix spacing between video and captionmediawiki/extensions/TimedMediaHandlermaster+8 -0
Customize query in gerrit

Event Timeline

TheDJ created this task.May 6 2022, 6:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2022, 6:44 AM
gerritbot added a comment.May 6 2022, 6:53 AM

Change 789768 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Fix spacing between video and caption

https://gerrit.wikimedia.org/r/789768

gerritbot added a project: Patch-For-Review.May 6 2022, 6:53 AM
gerritbot added a comment.May 6 2022, 6:46 PM

Change 789768 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Fix spacing between video and caption

https://gerrit.wikimedia.org/r/789768

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 6 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 6 2022, 7:30 PM
TheDJ closed this task as Resolved.May 6 2022, 7:45 PM
TheDJ claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL