Page MenuHomePhabricator
Create Task
Maniphest T308078

Reflow on non existent pages with no related articles
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Expected **

No cumulative layout shift

What happens?:

ra.gif (707×875 px, 221 KB)

What should have happened instead?:

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

SubjectRepoBranchLines +/-
Pages that do not exist shouldn't output related articlesmediawiki/extensions/RelatedArticlesmaster+24 -13
Don't add related articles container to pages it doesn't belongmediawiki/extensions/RelatedArticlesmaster+0 -0
Customize query in gerrit

Event Timeline

Jdlrobson created this task.May 10 2022, 10:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2022, 10:14 PM
gerritbot added a comment.May 10 2022, 10:23 PM

Change 790770 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] Don't add related articles container to pages it doesn't belong

https://gerrit.wikimedia.org/r/790770

gerritbot added a project: Patch-For-Review.May 10 2022, 10:23 PM

Change 790769 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] Pages that do not exist shouldn't output related articles

https://gerrit.wikimedia.org/r/790769

gerritbot added a comment.May 10 2022, 10:24 PM

Change 790770 abandoned by Jdlrobson:

[mediawiki/extensions/RelatedArticles@master] Don't add related articles container to pages it doesn't belong

Reason:

https://gerrit.wikimedia.org/r/790770

Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).May 11 2022, 1:39 AM
Jdlrobson moved this task from Backlog to UI Regression Testing on the Web-Team-Backlog (Needs Prioritization (Tech)) board.May 11 2022, 3:18 AM
gerritbot added a comment.May 11 2022, 7:34 PM

Change 790769 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] Pages that do not exist shouldn't output related articles

https://gerrit.wikimedia.org/r/790769

Jdlrobson closed this task as Resolved.May 11 2022, 7:43 PM
Jdlrobson claimed this task.
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).

Order has almost been restored to https://pixel.wmcloud.org/mobile/index.html :)

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 11 2022, 11:30 PM
Maintenance_bot removed a project: Patch-For-Review.May 11 2022, 11:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL