Page MenuHomePhabricator

Escape special characters in results
Closed, ResolvedPublic

Description

Reproduce:

  1. Run the following query against wikidatawiki_p: SELECT * FROM comment ORDER BY comment_id DESC LIMIT 1000;
  2. Export the result as Wikitable

You may find comment_text of a number of results containing pipe character (|) which will break Wikitable. This should be converted to HTML entity.

(I only tested Wikitable. I am not sure whether similar issues would exist in other formats.)

Event Timeline

Change 816254 had a related patch set uploaded (by WelpThatWorked; author: WelpThatWorked):

[analytics/quarry/web@master] Escape '|' from wikitable output

https://gerrit.wikimedia.org/r/816254

Change 816254 merged by jenkins-bot:

[analytics/quarry/web@master] Escape '|' from wikitable output

https://gerrit.wikimedia.org/r/816254

Change 821283 had a related patch set uploaded (by Vivian Rook; author: Vivian Rook):

[analytics/quarry/web@master] Switch string and pipe

https://gerrit.wikimedia.org/r/821283

Change 821283 merged by jenkins-bot:

[analytics/quarry/web@master] Switch string and pipe

https://gerrit.wikimedia.org/r/821283