Page MenuHomePhabricator
Create Task
Maniphest T308634

Find better suited icons for `API URL` and `Translate URL` in Edit Tool
Closed, ResolvedPublic
Actions

Description

If you navigate to https://toolhub.wikimedia.org/tools/xtools-ec/edit, you will see that the fields called <API URL>, <Bug Tracker URL> and <Translate URL> all use the same icon representing a bug.

The task is to change the <API URL> and <Translate URL> icons to something more suitable.

Steps:

  • Find the place in the code base where the icons are set
  • Go to https://materialdesignicons.com/
  • Browse the icons and choose the ones you want. Take note of the icon names
  • Prefix the icon names with mdi-, swapping out the old icons with the new ones

Details

SubjectRepoBranchLines +/-
ui: Updated icon for api url, translate url and bug tracker urlwikimedia/toolhubmain+4 -4
Customize query in gerrit

Event Timeline

Slst2020 created this task.May 18 2022, 6:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2022, 6:54 AM
Slst2020 renamed this task from Find better suited icons for `API URL` and `Translate URL` in Edit Tool to [Toolhub] Find better suited icons for `API URL` and `Translate URL` in Edit Tool.May 18 2022, 6:55 AM
Slst2020 renamed this task from [Toolhub] Find better suited icons for `API URL` and `Translate URL` in Edit Tool to Find better suited icons for `API URL` and `Translate URL` in Edit Tool.
Slst2020 moved this task from Backlog to Projects for Newcomers! on the Wikimedia-Hackathon-2022 board.
Slst2020 triaged this task as Medium priority.May 18 2022, 6:57 AM
gokulvamsi claimed this task.May 22 2022, 10:00 AM
gokulvamsi added a comment.May 22 2022, 10:05 AM

Hello @Slst2020! Please review my patch: https://gerrit.wikimedia.org/r/c/wikimedia/toolhub/+/795178

gerritbot added a comment.May 22 2022, 11:16 AM

Change 795178 had a related patch set uploaded (by Slavina Stefanova; author: Gokul Vamsi):

[wikimedia/toolhub@main] ui: Updated icon for api url, translate url and bug tracker url

https://gerrit.wikimedia.org/r/795178

gerritbot added a project: Patch-For-Review.May 22 2022, 11:16 AM
gerritbot added a comment.May 22 2022, 11:36 AM

Change 795178 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: Updated icon for api url, translate url and bug tracker url

https://gerrit.wikimedia.org/r/795178

Slst2020 added a comment.May 22 2022, 11:37 AM
In T308634#7947947, @gokulvamsi wrote:

Hello @Slst2020! Please review my patch: https://gerrit.wikimedia.org/r/c/wikimedia/toolhub/+/795178

Merged now, thank you!

You will see that I updated the commit message to link the patch to this task here in Phabricator.

Maintenance_bot removed a project: Patch-For-Review.May 22 2022, 12:30 PM
bd808 subscribed.May 22 2022, 3:41 PM

This change is live at https://toolhub-demo.wmcloud.org/. Thank you for your contribution @gokulvamsi!

Slst2020 closed this task as Resolved.May 23 2022, 5:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits