Page MenuHomePhabricator

Bump revscoring to 2.11.4 on our Docker images for Lift Wing
Closed, ResolvedPublic

Description

I know that the first thought while reading the task's title was "oh no please, not another dependency hell.." :D

I think that we should bump revscoring to 2.11.4 in our Docker images, and change the dependencies that breaks. I see multiple benefits:

  1. We keep the same version on ORES and Lift Wing. I don't think it makes a lot of sense to replace ORES if we don't have a complete feature parity. We have 2.11.1 on ORES but we'll deploy 2.11.4 soon.
  1. In T296173#7952700 there is a good example of problems that we'll encounter if we are not used to bump revscoring. Aiko tried to jump to kserve 0.8 (something that we'll likely have to do soon) and there was a problem with numpy deps, that we can probably fix with a new release of revscoring. If we keep lagging behind we'll not be able to rapidly fix these issues over time.
  1. Security fixes will become harder and harder the more we lag in Docker images.

Let me know your thoughts! It shouldn't be too painful to test one Docker image and see how it goes with revscoring 2.11.4, then we can decide how much work will be needed to migrate them all.

Event Timeline

elukey removed achou as the assignee of this task.
elukey moved this task from Parked to In Progress on the Machine-Learning-Team (Active Tasks) board.
elukey moved this task from In Progress to Parked on the Machine-Learning-Team (Active Tasks) board.

Change 799275 had a related patch set uploaded (by Elukey; author: Elukey):

[machinelearning/liftwing/inference-services@main] editquality: upgrade revscoring to 2.11.4

https://gerrit.wikimedia.org/r/799275

Change 799275 merged by jenkins-bot:

[machinelearning/liftwing/inference-services@main] editquality: upgrade revscoring to 2.11.4

https://gerrit.wikimedia.org/r/799275

Change 799328 had a related patch set uploaded (by Elukey; author: Elukey):

[operations/deployment-charts@master] ml-services: update image for enwiki goodfaith

https://gerrit.wikimedia.org/r/799328

Change 799328 merged by Elukey:

[operations/deployment-charts@master] ml-services: update image for enwiki goodfaith

https://gerrit.wikimedia.org/r/799328

The enwiki-goodfaith pod is now running revscoring 2.11.4 and I can successfully get scores without any weird error logged. I'll follow up with a code change to apply it to the other pods.

Change 799349 had a related patch set uploaded (by Elukey; author: Elukey):

[operations/deployment-charts@master] ml-services: update docker image for revscoring-editquality-*

https://gerrit.wikimedia.org/r/799349

For articlequality, we need to first solve T309205 to release the new version of articlequality in Pypi.

Change 799349 merged by Elukey:

[operations/deployment-charts@master] ml-services: update docker image for revscoring-editquality-*

https://gerrit.wikimedia.org/r/799349

Change 800025 had a related patch set uploaded (by Elukey; author: Elukey):

[machinelearning/liftwing/inference-services@main] articlequality: update dependencies to use revscoring 2.11.4

https://gerrit.wikimedia.org/r/800025

Change 800032 had a related patch set uploaded (by Elukey; author: Elukey):

[machinelearning/liftwing/inference-services@main] draftquality: update dependencies to use revscoring 2.11.4

https://gerrit.wikimedia.org/r/800032

Change 800025 merged by jenkins-bot:

[machinelearning/liftwing/inference-services@main] articlequality: update dependencies to use revscoring 2.11.4

https://gerrit.wikimedia.org/r/800025

Change 800032 merged by jenkins-bot:

[machinelearning/liftwing/inference-services@main] draftquality: update dependencies to use revscoring 2.11.4

https://gerrit.wikimedia.org/r/800032

Change 800732 had a related patch set uploaded (by Elukey; author: Elukey):

[operations/deployment-charts@master] ml-services: bump docker image for draftquality

https://gerrit.wikimedia.org/r/800732

Change 800732 merged by Elukey:

[operations/deployment-charts@master] ml-services: bump docker image for draftquality

https://gerrit.wikimedia.org/r/800732

All pods running revscoring 2.11.4. Tested various endpoints and I can see scores correctly, no errors in the logs.