The upgrade to Netbox 3.2 brings Provider Networks objects:
https://docs.netbox.dev/en/stable/core-functionality/circuits/
or:
https://netbox-next.wikimedia.org/circuits/provider-networks/1/
I don't see a huge benefit for this feature (eg. for automation), but it's easy to implement and will help documenting our infrastructure properly (eg. it allows adding X-connect and patch panel on the Z-side if needed)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| wmf-netbox: simplify interface description for circuits | operations/software/homer/deploy | master | +10 -35 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ayounsi | T310591 Netbox: use Provider Networks | |||
| Resolved | ayounsi | T296452 Upgrade Netbox to 3.2 | |||
| Stalled | None | T234997 Make Netbox Active/Active | |||
| Resolved | ayounsi | T311385 Netbox and Redis | |||
| Stalled | None | T330084 gdnsd failures when converting services from active/passive to active/active |
Assiging a provider network to a circuit causes:
Traceback (most recent call last):
File "/srv/deployment/homer/venv-1655301229/lib/python3.9/site-packages/homer/netbox.py", line 46, in __getitem__
self.data[key] = getattr(self, method_name)()
File "/srv/deployment/homer/venv-1655301229/lib/python3.9/site-packages/homer_plugins/wmf-netbox.py", line 412, in _get_junos_interfaces
interface_config['description'] = self.interface_description(interface_name)
File "/srv/deployment/homer/venv-1655301229/lib/python3.9/site-packages/homer_plugins/wmf-netbox.py", line 358, in interface_description
vc = termination.link_peer.device.virtual_chassis
AttributeError: 'NoneType' object has no attribute 'device'As so far the code assumes that if there is a link_peer, there is a device.
Change 805898 had a related patch set uploaded (by Ayounsi; author: Ayounsi):
[operations/software/homer/deploy@master] wmf-netbox: don't crash with "provider network"
Change 805898 merged by Ayounsi:
[operations/software/homer/deploy@master] wmf-netbox: simplify interface description for circuits