Page MenuHomePhabricator

"older revision" link displayed when viewing first revision of an article
Closed, ResolvedPublic

Description

Author: Saintonge

Description:
When reviewing a previous version of an artilcle on Wikisource, the new software
conveniently shows links to the immediately prior and next edits.

However, when we arrive at the first version of the article the prior version
link still appears even though no older version exists. Clicking on the link
simply reloads the same version that we are already viewing.


Version: 1.4.x
Severity: minor

Details

Reference
bz1122
TitleReferenceAuthorSource BranchDest Branch
Data checks for data pipeline outputsrepos/structured-data/image-suggestions!2cparleT312235main
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:07 PM
bzimport set Reference to bz1122.
bzimport added a subscriber: Unknown Object (MLST).

rowan.collins wrote:

[fixing description fields: this isn't a problem with the way the websites are
set up, it's a minor bug in the software]

rowan.collins wrote:

Note that in 1.5-cvs, it is possible to view the current revision as a
historical revision (since it has a unique ID); this may be useful (cf bug 2214)
but means that this revision also needs special handling wrt navigation links.
Currently:

  • on the oldest revision of a page, the "older revision" link leads round to

itself, as already described (it should probably be suppressed in favour of a
message saying "No older revisions" or "Oldest revision")

  • on the newest revision of a page, the "newer revision" link leads to the same

place as the "current revision" link - confusingly, this loads the same revision
you're already looking at, but as a normal page, not a historical revision,
thereby removing the "revision as of" notice and history navigation links. (To
be clear: this makes sense for the "current revision" link, but not as a "newer
revision" as there is no such thing; instead, a message such as "No newer
revisions" or "Newest revision" should be displayed.)

As an example, navigate the history of
http://test.leuksman.com/index.php?title=HARBL&oldid=6877 - which has just two
revisions.

zigger wrote:

*** Bug 2565 has been marked as a duplicate of this bug. ***

wiki.bugzilla wrote:

*** Bug 4513 has been marked as a duplicate of this bug. ***

Fixed in REL1_5 and HEAD, will be in 1.5.6.

gangleri wrote:

Sorry!

This fix probably caused
Bug 4826: Missing summary and link to Contributor at "earliest revision"

best regards reinhardt [[user:gangleri]]