Page MenuHomePhabricator

TestThankRevisionErrors.test_invalid_revision giving error
Closed, ResolvedPublic

Description

How to reproduce:

export PYWIKIBOT_TEST_WRITE_FAIL=1
python3 pwb.py -site:wikipedia:test thanks_tests -v TestThankRevisionErrors.test_invalid_revision

gives:

tests: max_retries reduced from 15 to 1
test_invalid_revision (__main__.TestThankRevisionErrors)
Test that passing an invalid revision ID causes an error. ...  120.137s FAIL

======================================================================
FAIL: test_invalid_revision (__main__.TestThankRevisionErrors)
Test that passing an invalid revision ID causes an error.
----------------------------------------------------------------------
pywikibot.exceptions.APIError: badinteger: Invalid value "0.99" for integer parameter "rev".
[help: See https://test.wikipedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/> for notice of API deprecations and breaking changes.]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/rook/git/core/tests/thanks_tests.py", line 109, in test_invalid_revision
    self.assertAPIError('invalidrevision', None, site.thank_revision,
  File "/home/rook/git/core/tests/aspects.py", line 290, in assertAPIError
    return AssertAPIErrorContextManager(
  File "/home/rook/git/core/tests/utils.py", line 201, in handle
    callable_obj(*args, **kwargs)
  File "/home/rook/git/core/tests/utils.py", line 191, in __exit__
    self.test_case.assertEqual(exc_value.code, self.code)
AssertionError: 'badinteger' != 'invalidrevision'
- badinteger
+ invalidrevision


----------------------------------------------------------------------
Ran 1 test in 121.944s

FAILED (failures=1)

Event Timeline

Xqt triaged this task as High priority.Jul 16 2022, 9:27 AM
Xqt subscribed.

Looks like this behaviour is changed in MW 1.35
https://www.mediawiki.org/wiki/MediaWiki_1.35#Action%20API%20changes

Can this be confirmed?

Change 814275 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Update TestThankRevisionErrors.test_invalid_revision test

https://gerrit.wikimedia.org/r/814275

Change 814275 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Update TestThankRevisionErrors.test_invalid_revision test

https://gerrit.wikimedia.org/r/814275