Page MenuHomePhabricator

jquery.wikiEditor.js contains some iframe-specific code
Closed, ResolvedPublic

Description

jquery.wikiEditor.js contains what appears to be some iframe-specific code such as a 'keydown' event handler that deals with ctrl+z, ctrl+y, ctrl+v, and tab.

This calls into context.fn.* functions which only appear in jquery.wikiEditor.iframe.js, such as updateHistory() and purgeOffsets(). It also doesn't appear to actually get called at all in the regular textarea mode, which explains why we don't see errors from it. ;)

Probably just needs moving over to the extension file.


Version: unspecified
Severity: normal

Details

Reference
bz29322

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:29 PM
bzimport set Reference to bz29322.

Moved it over in r89778, seems fine.