OutputPageTest::testHeadItemsParserOutput TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Jul 30 2022, 3:07 AM

Description

Seems these lines in ProofreadPage appear in numerous stack traces with the same array_key_exists errors..

2) OutputPageTest::testHeadItemsParserOutput
TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given

/var/www/wiki/mediawiki/extensions/ProofreadPage/includes/Parser/TranslusionPagesModifier.php:88
/var/www/wiki/mediawiki/extensions/ProofreadPage/includes/Parser/TranslusionPagesModifier.php:59
/var/www/wiki/mediawiki/extensions/ProofreadPage/includes/ProofreadPage.php:261
/var/www/wiki/mediawiki/core/includes/HookContainer/HookContainer.php:338
/var/www/wiki/mediawiki/core/includes/HookContainer/HookContainer.php:137
/var/www/wiki/mediawiki/core/includes/HookContainer/HookRunner.php:2691
/var/www/wiki/mediawiki/core/includes/OutputPage.php:2151
/var/www/wiki/mediawiki/core/tests/phpunit/includes/OutputPageTest.php:379
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiIntegrationTestCase.php:498
/var/www/wiki/mediawiki/core/tests/phpunit/phpunit.php:101
/var/www/wiki/mediawiki/core/tests/phpunit/phpunit.php:153

Details

	Subject	Repo	Branch	Lines +/-
	TranslusionPagesModifier::getIncludedPagePagesTitles() short circuit if $templates is null	mediawiki/extensions/ProofreadPage	master	+1 -1

Customize query in gerrit

Event Timeline

Reedy created this task.Jul 30 2022, 3:07 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2022, 3:08 AM

Reedy updated the task description. (Show Details)Jul 30 2022, 3:08 AM

Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Jul 30 2022, 3:15 AM

Change 819187 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ProofreadPage@master] TranslusionPagesModifier::getIncludedPagePagesTitles() short circuit if $templates is null

https://gerrit.wikimedia.org/r/819187

gerritbot added a project: Patch-For-Review.Aug 1 2022, 11:03 PM

Change 819187 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] TranslusionPagesModifier::getIncludedPagePagesTitles() short circuit if $templates is null

https://gerrit.wikimedia.org/r/819187

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2022, 8:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 2 2022, 9:00 AM

Reedy closed this task as Resolved.Aug 2 2022, 5:24 PM

Reedy claimed this task.

OutputPageTest::testHeadItemsParserOutput TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null givenClosed, ResolvedPublicActions

Description

Details

Event Timeline

OutputPageTest::testHeadItemsParserOutput TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given
Closed, ResolvedPublic
Actions