Page MenuHomePhabricator
Create Task
Maniphest T314399

OutputPage::getUnprefixedDisplayTitle() is unreliable
Open, Needs TriagePublic
Actions

Description

The code in OutputPage::getUnprefixedDisplayTitle() seems broken. It likely doesn't work on multilingual wikis or Translate pages where page language is different from the content language, it probably doesn’t properly reflect the user’s chosen variant, it might not handle gendered namespaces, etc. The solution is probably to tweak the way the Parser and the DISPLAYTITLE parser function work in order to keep the namespace and the unprefixed title separate.

Details

SubjectRepoBranchLines +/-
WIP: use split display title in OutputPage/EditPage/Articlemediawiki/coremaster+35 -8
Store DISPLAYTITLE components in split formmediawiki/coremaster+158 -11
WIP: Don't allow {{DISPLAYTITLE}} and -{T|..}- to override namespace l10nmediawiki/coremaster+118 -24
Customize query in gerrit

Related Objects

Event Timeline

cscott created this task.Aug 2 2022, 3:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2022, 3:40 PM
gerritbot added a comment.Aug 2 2022, 3:41 PM

Change 810114 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: Don't allow {{DISPLAYTITLE}} and -{T|..}- to override namespace l10n

https://gerrit.wikimedia.org/r/810114

gerritbot added a project: Patch-For-Review.Aug 2 2022, 3:41 PM
cscott mentioned this in T310526: Parsoid read views doesn't support -{T|...}- page title markup.Aug 4 2022, 5:50 PM
cscott mentioned this in T293514: Unify ParserOutput::{get,set}{TitleText,DisplayTitle}.May 5 2023, 6:53 PM
gerritbot added a comment.Aug 8 2023, 6:18 PM

Change 946988 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Store DISPLAYTITLE components in split form

https://gerrit.wikimedia.org/r/946988

gerritbot added a comment.Aug 8 2023, 6:18 PM

Change 946989 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: use split display title in OutputPage/EditPage/Article

https://gerrit.wikimedia.org/r/946989

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL