Page MenuHomePhabricator

Redundant message about deleted files when uploading uses invalid HTML
Closed, ResolvedPublic

Description

On Special:Upload, if you're allowed to view deleted edits, there's a second redundant message about this fact that, and it uses invalid HTML (a duplicate id). I propose that we remove it.

This can be reproduced at https://test.wikipedia.org/w/index.php?title=Special:Upload&wpDestFile=Mood_dice.png.

image.png (2×3 px, 650 KB)

  • Blue marker: the normal <div id="contentSub2"></div> element provided by the skin
  • Red marker: redundant message "View or undelete N deleted edits?", using the same id (only shown if you're allowed to view deleted edits)
  • Green marker: normal message "Warning: A file by that name has been deleted or moved. …" (always shown)

Both messages have existed for many years, one added in rSVN57868, the other in rSVN65339.

Event Timeline

Change 821314 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] SpecialUpload: Remove redundant message about deleted files

https://gerrit.wikimedia.org/r/821314

Change 821314 merged by jenkins-bot:

[mediawiki/core@master] SpecialUpload: Remove redundant message about deleted files

https://gerrit.wikimedia.org/r/821314

matmarex claimed this task.