ParserIntegrationTest failure on release branches after l10n update
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Aug 8 2022, 10:06 PM

Description

Seen on a no-op patch - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/821332; https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php73-docker/3462/console

23:03:31 1) ParserIntegrationTest::testParse with data set "parserTests.txt: Internal link with kaa linktrail with apostrophes (T29473)" ('[details omitted]')
23:03:31 Failed asserting that two strings are equal.
23:03:31 --- Expected
23:03:31 +++ Actual
23:03:31 @@ @@
23:03:31 -'<p><a href="/index.php?title=Something&amp;action=edit&amp;redlink=1" class="new" title="Something (bet ele jaratılmag&#39;an)">Something'nice</a>\n
23:03:31 +'<p><a href="/index.php?title=Something&amp;action=edit&amp;redlink=1" class="new" title="Something (bet ele jaratılmaǵan)">Something'nice</a>\n
23:03:31  </p>'
23:03:31 
23:03:31 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:65
23:03:31 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:25
23:03:31 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:25
23:03:31 /workspace/src/maintenance/doMaintenance.php:107

Details

Subject	Repo	Branch	Lines +/-
tests: Update parser test after i18n change	mediawiki/services/parsoid	REL1_37	+2 -2
tests: Update parser test after i18n change	mediawiki/core	REL1_38	+1 -1
tests: Update parser test after i18n change	mediawiki/core	REL1_37	+1 -1
tests: Update parser test after i18n change	mediawiki/core	REL1_35	+1 -1

Customize query in gerrit

Event Timeline

Reedy created this task.Aug 8 2022, 10:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2022, 10:06 PM

Change 821325 had a related patch set uploaded (by Arlolra; author: Umherirrender):

[mediawiki/core@REL1_35] tests: Update parser test after i18n change

https://gerrit.wikimedia.org/r/821325

gerritbot added a project: Patch-For-Review.Aug 9 2022, 12:24 AM

cf IRC my own comment... Which also means it's gonna break on REL1_37 "today", and REL1_38 "tomorrow"

Reedy renamed this task from ParserIntegrationTest failure on MW 1.35 to ParserIntegrationTest failure on release branches after l10n update.Aug 9 2022, 12:49 AM

Reedy triaged this task as High priority.

Change 821325 merged by jenkins-bot:

[mediawiki/core@REL1_35] tests: Update parser test after i18n change

https://gerrit.wikimedia.org/r/821325

ReleaseTaggerBot added a project: MW-1.35-notes.Aug 9 2022, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 9 2022, 1:30 AM

Change 821339 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_37] tests: Update parser test after i18n change

https://gerrit.wikimedia.org/r/821339

gerritbot added a project: Patch-For-Review.Aug 9 2022, 7:24 AM

Change 821340 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_38] tests: Update parser test after i18n change

https://gerrit.wikimedia.org/r/821340

Change 821339 merged by jenkins-bot:

[mediawiki/core@REL1_37] tests: Update parser test after i18n change

https://gerrit.wikimedia.org/r/821339

ReleaseTaggerBot added a project: MW-1.37-notes.Aug 9 2022, 8:00 AM

Change 821340 merged by jenkins-bot:

[mediawiki/core@REL1_38] tests: Update parser test after i18n change

https://gerrit.wikimedia.org/r/821340

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2022, 6:30 AM

ReleaseTaggerBot added a project: MW-1.38-notes.Aug 10 2022, 7:00 AM

Reedy closed this task as Resolved.Aug 10 2022, 2:32 PM

Reedy claimed this task.

Change 823263 had a related patch set uploaded (by Arlolra; author: Umherirrender):

[mediawiki/services/parsoid@REL1_37] tests: Update parser test after i18n change

https://gerrit.wikimedia.org/r/823263

gerritbot added a project: Patch-For-Review.Aug 15 2022, 10:32 PM

Change 823263 merged by jenkins-bot: