Page MenuHomePhabricator

Evaluation Error on deployment-cache-text06 puppet run
Closed, ResolvedPublic

Description

samtar@deployment-cache-text06:~$ sudo run-puppet-agent
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Class[Trafficserver] is already declared at (file: /etc/puppet/modules/trafficserver/manifests/instance.pp, line: 251); cannot redeclare (file: /etc/puppet/modules/trafficserver/manifests/instance.pp, line: 251) (file: /etc/puppet/modules/trafficserver/manifests/instance.pp, line: 251, column: 5) (file: /etc/puppet/modules/profile/manifests/trafficserver/tls.pp, line: 168) on node deployment-cache-text06.deployment-prep.eqiad.wmflabs
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

Event Timeline

RhinosF1 triaged this task as Unbreak Now! priority.Aug 16 2022, 8:56 PM
RhinosF1 added projects: Traffic, Puppet.

Hi Traffic, this might be stopping beta coming back up (or a false alarm). Can you take a look?

Introduced by https://gerrit.wikimedia.org/r/c/operations/puppet/+/816806 ref. T309651: Package and deploy ATS 9.1.3

diff --git a/modules/trafficserver/manifests/instance.pp b/modules/trafficserver/manifests/instance.pp
index af3c6d3..cd42ec4 100644
--- a/modules/trafficserver/manifests/instance.pp
+++ b/modules/trafficserver/manifests/instance.pp

@@ -248,7 +248,9 @@
     Boolean                                         $is_ats9                 = false,
 ) {
 
-    require ::trafficserver
+    class { 'trafficserver':
+      install_ats9 => $is_ats9,
+    }
     $user = $trafficserver::user  # needed by udev_storage.rules.erb and records.config.erb
 
     if !defined('$http_port') and !defined('$https_port') {
Zabe added a subscriber: Zabe.

Some cherry-picks made by ori made puppet run again, see T315394 for follow-up.