Page MenuHomePhabricator

Errors during translation should be caught and included in the template output
Open, MediumPublic

Description

As described in T308171 and T311519, template errors are causing translation to fail altogether, instead of proceeding with the following template on the queue.

Consider marking templates as non-applicable in these cases.

However, including the error somewhere in the template output would be useful to diagnose the problem from the Web2Cit-Server debugging information, or from the Web2Cit-Editor, which already includes in its data model a place to store such errors.

Event Timeline

diegodlh triaged this task as Medium priority.Sep 9 2022, 7:48 PM
diegodlh created this task.

including the error somewhere in the template output would be useful to diagnose the problem

Some errors are already caught, therefore not preventing translation from proceeding, but it would still be useful to log them to help diagnose problems:

  • translation step invalid configurations: Web2Cit ignores the problematic step;
  • templates without one of mandatory fields: Web2Cit ignores the template silently;

At the very least, template output may include an "errors" array including all errors caught during its execution (see T302431). The Web2Cit-Server may print this to a new per-template "errors" row or property in the html or json formats, respectively.

diegodlh renamed this task from Template errors should be caught and not prevent translation from proceeding to Errors during translation should be caught and included in the template output.Sep 14 2022, 6:39 PM

Some errors are already caught (...) but it would still be useful to log them to help diagnose problems:

  • After fixing T305163, this would also include errors during application of translation steps.

Maybe including errors this way may help with T317877.