memento.get_closest_memento_url fails with AttributeError due to datetime
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Xqt
	Sep 10 2022, 11:03 AM

Description

Steps to replicate the issue:

Run a script which is using get_closest_memento_url without giving a 'when' parameter e.g. weblinkchecker

What happens?:

>>> (10000) Myriostos <<<
WARNING: Http response status 403
*[[(10) Hygiea]] links to https://www.ncbi.nlm.nih.gov/pmc/articles/PMC1085085/ - Forbidden.
WARNING: get_closest_memento_url(https://www.ncbi.nlm.nih.gov/pmc/articles/PMC1085085/) failed: type object 'datetime.datetime' has no attribute 'datetime'
** Logging link for deletion.

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Fix AttributeError in memento.get_closest_memento_url	pywikibot/core	master	+7 -10

Customize query in gerrit

Event Timeline

Xqt created this task.Sep 10 2022, 11:03 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptSep 10 2022, 11:03 AM

Xqt changed the task status from Open to In Progress.Sep 10 2022, 11:03 AM

Xqt claimed this task.

Xqt triaged this task as High priority.

Change 831181 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Fix AttributeError in memento.get_closest_memento_url

https://gerrit.wikimedia.org/r/831181

gerritbot added a project: Patch-For-Review.Sep 10 2022, 11:20 AM

Xqt closed this task as Resolved.Sep 10 2022, 7:00 PM

Change 831181 merged by jenkins-bot: