Page MenuHomePhabricator
Create Task
Maniphest T318754

"Advanced configuration" is nested in "Personalization"
Closed, ResolvedPublic
Actions

Description

Screenshot 2022-09-27 at 22.33.19.png (594×982 px, 90 KB)

Details

SubjectRepoBranchLines +/-
WebInstallerOptions::addPersonalizationOptions(): Close fieldsetmediawiki/coreREL1_38+2 -1
WebInstallerOptions::addPersonalizationOptions(): Close fieldsetmediawiki/coreREL1_39+2 -1
WebInstallerOptions::addPersonalizationOptions(): Close fieldsetmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Sep 27 2022, 9:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2022, 9:35 PM
Reedy added a comment.Sep 27 2022, 9:39 PM

Fallout from rMW9bd3af32fc4e: Update installer to reflect modern logos? An unclosed element or something?

gerritbot added a comment.Sep 27 2022, 9:41 PM

Change 835703 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] WebInstallerOptions::addPersonalizationOptions(): Close fieldset

https://gerrit.wikimedia.org/r/835703

gerritbot added a project: Patch-For-Review.Sep 27 2022, 9:41 PM
Reedy added projects: MW-1.38-release, MW-1.39-release.Sep 27 2022, 9:41 PM
Reedy added a comment.Sep 27 2022, 9:58 PM

Also, the back/continue buttons are nested in the personalisation section too

Screenshot 2022-09-27 at 22.58.34.png (600×2 px, 108 KB)

gerritbot added a comment.Sep 28 2022, 3:14 PM

Change 835703 merged by jenkins-bot:

[mediawiki/core@master] WebInstallerOptions::addPersonalizationOptions(): Close fieldset

https://gerrit.wikimedia.org/r/835703

gerritbot added a comment.Sep 28 2022, 3:15 PM

Change 836192 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] WebInstallerOptions::addPersonalizationOptions(): Close fieldset

https://gerrit.wikimedia.org/r/836192

gerritbot added a comment.Sep 28 2022, 3:16 PM

Change 836193 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_38] WebInstallerOptions::addPersonalizationOptions(): Close fieldset

https://gerrit.wikimedia.org/r/836193

gerritbot added a comment.Sep 28 2022, 3:26 PM

Change 836192 merged by jenkins-bot:

[mediawiki/core@REL1_39] WebInstallerOptions::addPersonalizationOptions(): Close fieldset

https://gerrit.wikimedia.org/r/836192

ReleaseTaggerBot added projects: MW-1.40-notes (1.40.0-wmf.4; 2022-10-03), MW-1.39-notes.Sep 28 2022, 4:00 PM
gerritbot added a comment.Sep 28 2022, 7:23 PM

Change 836193 merged by Reedy:

[mediawiki/core@REL1_38] WebInstallerOptions::addPersonalizationOptions(): Close fieldset

https://gerrit.wikimedia.org/r/836193

Reedy closed this task as Resolved.Sep 28 2022, 7:39 PM
Reedy claimed this task.
ReleaseTaggerBot added a project: MW-1.38-notes.Sep 28 2022, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL