Page MenuHomePhabricator
Create Task
Maniphest T320362

Address phan failures for version bump of mediawiki/mediawiki-phan-config to 0.12.0
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/840429 there are several phan errors that need addressing before the version bump of mediawiki/mediawiki-phan-config to 0.12.0 can occur. These reported issues seem to be correctly reported and possibly previouly not addressed so code changes will need to be made. All occur in SpecialInvestigate.php so probably within the scope of Anti-Harassment.

Details

SubjectRepoBranchLines +/-
build: Updating mediawiki/mediawiki-phan-config to 0.12.0mediawiki/extensions/CheckUsermaster+4 -6
Address Phan upgrade errors in SpecialInvestigatemediawiki/extensions/CheckUsermaster+7 -1
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Oct 9 2022, 11:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2022, 11:36 PM
Dreamy_Jazz renamed this task from Address phan failures for version bump of mediawiki/mediawiki-phan-config to Address phan failures for version bump of mediawiki/mediawiki-phan-config to 0.12.0.Oct 9 2022, 11:37 PM
Dreamy_Jazz added a project: Anti-Harassment.
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz moved this task from General / Unsorted to Investigate on the CheckUser board.
Tchanders claimed this task.Oct 13 2022, 4:40 PM
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Oct 25 2022, 3:51 PM
gerritbot added a comment.Oct 25 2022, 3:57 PM

Change 849119 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Address Phan upgrade errors in SpecialInvestigate

https://gerrit.wikimedia.org/r/849119

gerritbot added a project: Patch-For-Review.Oct 25 2022, 3:57 PM
gerritbot added a comment.Oct 25 2022, 5:00 PM

Change 840429 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] build: Updating mediawiki/mediawiki-phan-config to 0.12.0

https://gerrit.wikimedia.org/r/840429

gerritbot added a comment.Oct 25 2022, 5:01 PM

Change 849119 abandoned by Tchanders:

[mediawiki/extensions/CheckUser@master] Address Phan upgrade errors in SpecialInvestigate

Reason:

Squashed into Ibd20052797e578bc8d150e8e67be6979cbe8946e

https://gerrit.wikimedia.org/r/849119

• TThoabala set the point value for this task to 1.Oct 26 2022, 4:16 PM
Tchanders moved this task from Triage/To be Estimated to AHaT Sprint 19: The Deerstalker on the Anti-Harassment board.Oct 27 2022, 3:37 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 19: The Deerstalker); removed Anti-Harassment.
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 19: The Deerstalker) board.
Dreamy_Jazz moved this task from Investigate to Patches for review on the CheckUser board.Oct 31 2022, 11:45 AM
gerritbot added a comment.Nov 1 2022, 1:40 PM

Change 840429 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] build: Updating mediawiki/mediawiki-phan-config to 0.12.0

https://gerrit.wikimedia.org/r/840429

Tchanders moved this task from Code Review 🔍 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 19: The Deerstalker) board.Nov 1 2022, 1:46 PM

Nothing to QA here.

Dreamy_Jazz closed this task as Resolved.Nov 1 2022, 1:52 PM
Dreamy_Jazz moved this task from Patches for review to Investigate on the CheckUser board.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 1 2022, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits