Maniphest T320387

Function view: Alias list for additional languages always have an empty string as first item
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	gengh
	Oct 10 2022, 10:08 AM

Description

Steps to reproduce:

Go to https://wikifunctions.beta.wmflabs.org/wiki/Z10014?view=function-viewer
Expand "Also known as" --> "Show more languages"

Observed behavior:

There's two aliases for Swedish, and the first one is an empty string.

Expected behavior (Acceptance criteria):

According to the ZObject JSON, there should only be one Swedish alias "och":

{
    "Z1K1": "Z31",
    "Z31K1": "Z1592",
    "Z31K2": [
        "Z6",
        "och"
    ]
}

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

	Subject	Repo	Branch	Lines +/-
	Function view: Fix alias list for additional languages always have an empty string as first item	mediawiki/extensions/WikiLambda	master	+2 -2

Customize query in gerrit

Event Timeline

gengh renamed this task from <Component>: <Short one-liner describing the problem> to Function view: Alias list for additional languages always have an empty string as first item.Oct 10 2022, 10:08 AM

gengh created this task.

gengh moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.

gengh edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

gengh moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.

Ddwaal claimed this task.Oct 11 2022, 9:01 PM

Change 840582 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Function view: Fix alias list for additional languages always have an empty string as first item

https://gerrit.wikimedia.org/r/840582

gerritbot added a project: Patch-For-Review.Oct 11 2022, 9:51 PM

Change 840582 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Function view: Fix alias list for additional languages always have an empty string as first item

https://gerrit.wikimedia.org/r/840582

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 12 2022, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2022, 3:29 PM

A unit test wouldn't really help pick this up on the page as the updated getter is mocked. I will look to include it in an integration test.

Ddwaal moved this task from Ready: G4. Function view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Oct 14 2022, 1:08 PM

@Ddwaal-WMF can you share the state of this being included in integration tests? If it is, then I believe we can close this task.

gengh closed this task as Resolved.Oct 26 2022, 1:25 PM

Function view: Alias list for additional languages always have an empty string as first itemClosed, ResolvedPublicBUG REPORTActions

Description

Description

Completion checklist

Details

Event Timeline

Function view: Alias list for additional languages always have an empty string as first item
Closed, ResolvedPublicBUG REPORT
Actions