Maniphest T320586

Implement PreferencesGetLayout hook in Minerva
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jsn.sherman
	Oct 12 2022, 1:04 AM

Tags

Referenced Files

None

Subscribers

Masumrezarock100

Description

Now that we have PreferencesGetLayout defined in core, per T311717: Display Special:Preferences as a vertical menu instead of tabs on mobile for AMC users, we need to implement the hook in Minerva to enable the layout in the skin.

Details

	Subject	Repo	Branch	Lines +/-
	hooks: implement PreferencesGetLayout	mediawiki/skins/MinervaNeue	master	+16 -0
	[WIP] hooks: implement PreferencesGetLayout	mediawiki/skins/MinervaNeue	master	+15 -1

Customize query in gerrit

Related Objects

Mentioned In: T311717: Display Special:Preferences as a vertical menu instead of tabs on mobile for AMC users
Mentioned Here: T311717: Display Special:Preferences as a vertical menu instead of tabs on mobile for AMC users

Event Timeline

jsn.sherman created this task.Oct 12 2022, 1:04 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 12 2022, 1:04 AM

Change 834066 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/skins/MinervaNeue@master] [WIP] hooks: implement PreferencesGetLayout

https://gerrit.wikimedia.org/r/834066

gerritbot added a project: Patch-For-Review.Oct 12 2022, 1:06 AM

jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.Oct 12 2022, 1:14 AM

Samwalton9-WMF mentioned this in T311717: Display Special:Preferences as a vertical menu instead of tabs on mobile for AMC users.Oct 12 2022, 10:39 AM

Change 841921 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/skins/MinervaNeue@master] [WIP] hooks: implement PreferencesGetLayout

https://gerrit.wikimedia.org/r/841921

jsn.sherman updated the task description. (Show Details)Oct 13 2022, 2:03 AM

Change 834066 abandoned by Jsn.sherman:

[mediawiki/skins/MinervaNeue@master] [WIP] hooks: implement PreferencesGetLayout

Reason:

Abandoned in favor of another functionally identical change request

https://gerrit.wikimedia.org/r/834066

jsn.sherman moved this task from In Progress to Done on the Moderator-Tools-Team (Kanban) board.Oct 13 2022, 2:15 AM

jsn.sherman moved this task from Done to Code review on the Moderator-Tools-Team (Kanban) board.

Change 841921 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] hooks: implement PreferencesGetLayout

https://gerrit.wikimedia.org/r/841921

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2022, 4:29 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 13 2022, 5:00 PM

jsn.sherman moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Oct 14 2022, 10:38 AM

Samwalton9-WMF closed this task as Resolved.Oct 25 2022, 2:40 PM