Page MenuHomePhabricator
Create Task
Maniphest T321492

Vue layer is not converting implementation or tester objects to JSON before sending them in wikilambda_perform_test request
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Steps to reproduce:

  • Go to the edit page for an implementation

Observed behavior:

Array of implementations included in wikilambda_perform_test includes the string '[object Object]' for the current implementation as it has not been converted to JSON

Expected behavior (Acceptance criteria):

Should be JSON

Completion checklist

Details

SubjectRepoBranchLines +/-
Fix flow where expanded implementation is sent to API for perform_test.mediawiki/extensions/WikiLambdamaster+419 -250
Customize query in gerrit

Event Timeline

EWright claimed this task.Oct 24 2022, 2:31 PM
EWright created this task.
EWright edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
EWright moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.Oct 24 2022, 3:43 PM
gerritbot added a comment.Nov 4 2022, 4:35 PM

Change 849120 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/extensions/WikiLambda@master] Fix flow where expanded implementation is sent to API for perform_test.

https://gerrit.wikimedia.org/r/849120

gerritbot added a project: Patch-For-Review.Nov 4 2022, 4:35 PM
gerritbot added a comment.Nov 7 2022, 5:34 PM

Change 849120 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix flow where expanded implementation is sent to API for perform_test.

https://gerrit.wikimedia.org/r/849120

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2022, 6:31 PM
EWright added a comment.Nov 8 2022, 10:13 AM
This comment was removed by EWright.
EWright moved this task from Ready: G4. Function view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 11 2022, 3:35 PM

The above patch ensured both implementations and testers are converted to JSON.

gengh closed this task as Resolved.Nov 15 2022, 6:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits