Page MenuHomePhabricator

Empty page when editing a File: page on mobile
Open, Needs TriagePublicBUG REPORT

Description

A Commons user reported this during design research.

The toolbar edit button for the Minerva mobile UI does not work as expected. It does not provide access to edit any content on the page.

Steps to replicate the issue (include links if applicable):

  1. Open any Commons file using mobile web
  2. Tap the edit button in the toolbar above the image

What happens?:

There is no content to edit. A message in the edit box reads: "This section is empty. Be the first to expand it!"

What should have happened instead?:

The edit box should include some content to edit. This might include the entire page given the simplicity of Commons file pages.

Alternatively, do not include the edit button in the toolbar.

Other information (browser name/version, screenshots, etc.):

This bug also applies to Wiktionary.

Technical information

The toolbar edit button for the Minerva mobile UI affects everything from the beginning of the page to the first section header.

On Wikipedia that includes some initial metadata for the article. Every individual section has its own edit button which applies to that section. But there's a bit of content before the first section header. The toolbar edit button is coded to handle that initial pre-section content. It works fine for Wikipedia articles.

But on Commons the files actually start with a section header. There's zero pre-section content. But the edit button was coded for Wikipedia. It's only looking for content before the first section.

There's never any content to edit.

Using the toolbar edit button on Commons will create some phantom content before the first section header. It shows up after the file information panel and before the summary. It can thereafter be edited using the toolbar edit button.

This isn't an accessibility problem because all the sections do have their own edit button inline as you scroll the page.

It's mainly a problem because the toolbar edit button is useless.

There are two possible solutions. The easiest would be to remove the useless button. A better solution would be to change the functionality to edit the entire page (like the desktop edit button). Commons file pages are significantly less complex than Wikipedia articles. There are only two sections for file pages so it should not be prohibitive.

Note that Commons talk pages are more like Wikipedia. They do have content before the first section header. This content isn't generally useful to edit but the toolbar edit button works as designed.