Maniphest T322551

🚿️ Tidy up our use of ValidationError
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jakob_WMDE
	Nov 7 2022, 2:19 PM

Tags

Referenced Files

None

Subscribers

Description

In the past we've been abusing the "value" field of our ValidationError quite a bit. It used to always contain the exact value that failed the validation, but it now sometimes contains null, sometimes the limit of the validation. We recently introduced a flexible "context" field, which can be to store bad values or other context data.

Details

	Subject	Repo	Branch	Lines +/-
	REST: Replace ValidationError "source" with "code"	mediawiki/extensions/Wikibase	master	+245 -320
	REST: Remove ValidationError::getValue()	mediawiki/extensions/Wikibase	master	+192 -123
	REST: Make ValidationError::getContext() not nullable	mediawiki/extensions/Wikibase	master	+4 -4

Customize query in gerrit

Event Timeline

Jakob_WMDE created this task.Nov 7 2022, 2:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2022, 2:19 PM

Change 853934 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Make ValidationError::getContext() not nullable

https://gerrit.wikimedia.org/r/853934

gerritbot added a project: Patch-For-Review.Nov 7 2022, 2:41 PM

Change 853389 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove ValidationError::getValue()

https://gerrit.wikimedia.org/r/853389

Change 854013 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Replace ValidationError "source" with "code"

https://gerrit.wikimedia.org/r/854013

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 16) board.Nov 7 2022, 3:13 PM

Change 853934 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make ValidationError::getContext() not nullable

https://gerrit.wikimedia.org/r/853934

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 7 2022, 4:00 PM

Change 853389 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove ValidationError::getValue()

https://gerrit.wikimedia.org/r/853389

Change 854013 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Replace ValidationError "source" with "code"

https://gerrit.wikimedia.org/r/854013

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2022, 10:30 AM

Jakob_WMDE moved this task from Peer Review to Product Verification on the Wikibase Product Platform (v1) (Sprint 16) board.Nov 8 2022, 10:36 AM

Jakob_WMDE moved this task from Product Verification to Done on the Wikibase Product Platform (v1) (Sprint 16) board.

WMDE-leszek closed this task as Resolved.Dec 1 2022, 8:54 PM