wgLogo is inverted in DarkMode on MW1.39
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	MPThLee
	Nov 21 2022, 8:55 AM

Description

Maybe need to split into each issue.

Steps to replicate the issue (include links if applicable):

Install DarkMode extension. REL1_39 branch.
Enable Dark mode

What happens?:
(1. ~~T292697: Darkmode Background on longer pages is white~~

)

wgLogo inverted. Whatever legacy or vector 2022's vertical logo.

Check here too. Which is my testing wiki: https://new.shinycolors.wiki/wiki/Main_Page

What should have happened instead?:
No errors.

Software version (skip for WMF-hosted wikis like Wikipedia):

Mediawiki 1.39-rc.1
DarkMode extension REL1_39
PHP 8.0.25

Other information (browser name/version, screenshots, etc.):
Edge 107.0.1418.52 Windows.

Maybe It's not blocker for 1.39. Feel free to change tags.

(Renamed to reflect MW.1.41 is OK)

Related Objects

Mentioned In: T292697: Darkmode Background on longer pages is white
Mentioned Here: T292697: Darkmode Background on longer pages is white

Event Timeline

MPThLee created this task.Nov 21 2022, 8:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2022, 8:55 AM

MPThLee updated the task description. (Show Details)Nov 21 2022, 8:56 AM

Reedy renamed this task from DarkMode on 1.39-rc.1 is buggy. to DarkMode on 1.39-rc.1 is buggy.Nov 21 2022, 9:46 AM

Reedy moved this task from Blocker to Not a blocker on the MW-1.39-release board.

This looks like T292697 to me.

@R4356th Correct for 1. I will remove that.

MPThLee updated the task description. (Show Details)Dec 8 2022, 7:59 AM

MPThLee updated the task description. (Show Details)

MPThLee mentioned this in T292697: Darkmode Background on longer pages is white.Dec 8 2022, 9:09 AM

Aklapper renamed this task from DarkMode on 1.39-rc.1 is buggy to wgLogo is inverted in DarkMode on 1.39-rc.1.Dec 8 2022, 9:27 AM

Aklapper removed a project: MW-1.39-release.

Aklapper updated the task description. (Show Details)

Do you have a working link (the provided one does not have DarkMode right now) or a screenshot?

I disabled DarkMode on my wiki as there's site-wide css issue. I just tried on dev environment.

Vector legacy

msedge_mK5mD2M1A4.png (728×1 px, 100 KB)

msedge_VBxSBEm6lE.png (728×1 px, 103 KB)

Vector 2022

It's just default setting. with docker mediawiki images.

I think vector 2022 is fixed or configuration difference. (Image is default configuration, My wiki environment was $wgLogos = [ 'wordmark' => [ 'src' => "https://some.domain/wiki-wide-logo.svg" ] ]; without text.

Note: DarkMode version is DarkMode-REL1_39-1b4861a.tar.gz

In MW1.39, with logo colors being altered strangely though not fully inverted example:

https://helminthictherapywiki.org/wiki/Helminth_care (dark mode available for anon users)

Confirmed as fixed on MW.1.41, eg https://fallout-wiki.com/Accueil

(Edited to correct my mistake)

Aklapper renamed this task from wgLogo is inverted in DarkMode on 1.39-rc.1 to wgLogo is inverted in DarkMode.Jul 5 2023, 6:29 PM

Amousey renamed this task from wgLogo is inverted in DarkMode to wgLogo is inverted in DarkMode on MW1.39 .Jul 10 2023, 1:53 PM

Amousey updated the task description. (Show Details)

As pointed out by @Amousey, this has been fixed in recent versions. Is a backport needed?

	F37129544: IMG_8129.jpeg
	Jul 5 2023, 11:29 AM

	F37129545: IMG_8127.jpeg
	Jul 5 2023, 11:29 AM

wgLogo is inverted in DarkMode on MW1.39 Open, Needs TriagePublicBUG REPORTActions

Description

Related Objects

Event Timeline

wgLogo is inverted in DarkMode on MW1.39
Open, Needs TriagePublicBUG REPORT
Actions