Page MenuHomePhabricator

Please pull secret and/or configurable elements out of SwiftMedia/wmf/rewrite.py
Closed, ResolvedPublic

Description

Author: bhartshorne

Description:
Please put the following bits into a configuration file* to make managing the extension with puppet easier:

  • all the AUTH strings (lines 16, 23)
  • the host for the thumb media store (line 130)

Version: unspecified
Severity: normal

Details

Reference
bz30349

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:50 PM
bzimport set Reference to bz30349.

russnelson wrote:

The account is never going to change. It's the owner of the files in the Swift store. But still, why not put it in a config?

The auth string is a sample, since the variable is immediately overwritten by None. I deleted it.

But I also noticed the user-agent. I don't want to break the wiki by playing with it, but it should probably be settable to something other than Mozilla/5.0.

There's now a file called config.py which holds three config variables. It's running on alsted now. I'll check it in when I'm finished with other changes.