Page MenuHomePhabricator
Create Task
Maniphest T323586

Reduce number of published docker images for revscoring models
Closed, ResolvedPublic
Actions

Description

At the moment we are publishing 6 docker images every time we make a new release.
With the recent refactoring each revscoring model is an instance of the RevscoringModel Class.
This could allow us to have one image (with merged requirements.txt) with all the models and each deployment executes a different command for the corresponding model.

Details

SubjectRepoBranchLines +/-
revscoring: delete individual revscoring imagesmachinelearning/liftwing/inference-servicesmain+0 -1 K
inference-services: remove old revscoring pipelinesintegration/configmaster+0 -64
ml-services: use the same image for revscoring modelsoperations/deployment-chartsmaster+14 -14
blubber: create universal revscoring imagemachinelearning/liftwing/inference-servicesmain+353 -18
inference-services: add revscoring pipelinesintegration/configmaster+16 -0
blubber: create universal revscoring imagemachinelearning/liftwing/inference-servicesmain+61 -920
inference-services: add revscoring pipelinesintegration/configmaster+16 -0
inference-services: add revscoring pipelinesintegration/configmaster+16 -0
Customize query in gerrit

Related Objects

Event Timeline

isarantopoulos created this task.Nov 22 2022, 2:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2022, 2:26 PM
calbon assigned this task to isarantopoulos.Nov 22 2022, 3:13 PM
calbon moved this task from Unsorted to In Progress on the Machine-Learning-Team board.
gerritbot added a comment.Dec 7 2022, 2:57 PM

Change 865670 had a related patch set uploaded (by Ilias Sarantopoulos; author: Ilias Sarantopoulos):

[machinelearning/liftwing/inference-services@main] blubber: create universal revscoring image

https://gerrit.wikimedia.org/r/865670

gerritbot added a project: Patch-For-Review.Dec 7 2022, 2:57 PM
gerritbot added a comment.Dec 9 2022, 10:52 AM

Change 866560 had a related patch set uploaded (by Ilias Sarantopoulos; author: Ilias Sarantopoulos):

[integration/config@master] inference-services: add revscoring pipelines

https://gerrit.wikimedia.org/r/866560

gerritbot added a comment.Dec 9 2022, 11:35 AM

Change 866570 had a related patch set uploaded (by Ilias Sarantopoulos; author: Ilias Sarantopoulos):

[integration/config@master] inference-services: add revscoring pipelines

https://gerrit.wikimedia.org/r/866570

gerritbot added a comment.Dec 9 2022, 11:39 AM

Change 866571 had a related patch set uploaded (by Ilias Sarantopoulos; author: Ilias Sarantopoulos):

[integration/config@master] inference-services: add revscoring pipelines

https://gerrit.wikimedia.org/r/866571

gerritbot added a comment.Dec 9 2022, 11:43 AM

Change 866560 abandoned by Ilias Sarantopoulos:

[integration/config@master] inference-services: add revscoring pipelines

Reason:

duplicate

https://gerrit.wikimedia.org/r/866560

gerritbot added a comment.Dec 9 2022, 11:44 AM

Change 866571 abandoned by Ilias Sarantopoulos:

[integration/config@master] inference-services: add revscoring pipelines

Reason:

duplicate

https://gerrit.wikimedia.org/r/866571

gerritbot added a comment.Dec 9 2022, 2:13 PM

Change 866591 had a related patch set uploaded (by Ilias Sarantopoulos; author: Ilias Sarantopoulos):

[machinelearning/liftwing/inference-services@main] blubber: create universal revscoring image

https://gerrit.wikimedia.org/r/866591

gerritbot added a comment.Dec 9 2022, 2:15 PM

Change 866591 abandoned by Ilias Sarantopoulos:

[machinelearning/liftwing/inference-services@main] blubber: create universal revscoring image

Reason:

duplicate

https://gerrit.wikimedia.org/r/866591

isarantopoulos added a comment.Dec 9 2022, 2:19 PM

At the moment I have created one image for all revscoring models and managed to run inference through that. We build an image of approx 1.5GB instead of 4 images which should potentially speed up and make our CI/CD process a bit easier.
As you understand the changes in this patch are too many so it requires extensive QA on our side.
Remaining things:

  • merge the patch in the integration/config repo for the new deployment pipeline
  • update deployment charts to use the same image for all revscoring models
isarantopoulos added a comment.Dec 9 2022, 2:29 PM

My suggestion to proceed would be the following:

  • introduce new image, deploy and test it wherever we want
  • deprecate old files and pipelines.
gerritbot added a comment.Dec 12 2022, 10:26 AM

Change 866570 merged by jenkins-bot:

[integration/config@master] inference-services: add revscoring pipelines

https://gerrit.wikimedia.org/r/866570

gerritbot added a comment.Dec 15 2022, 1:21 PM

Change 865670 merged by jenkins-bot:

[machinelearning/liftwing/inference-services@main] blubber: create universal revscoring image

https://gerrit.wikimedia.org/r/865670

isarantopoulos mentioned this in rMLIS3b953485cc99: blubber: create universal revscoring image.Dec 15 2022, 1:22 PM
gerritbot added a comment.Dec 15 2022, 1:53 PM

Change 868407 had a related patch set uploaded (by Ilias Sarantopoulos; author: Ilias Sarantopoulos):

[operations/deployment-charts@master] ml-services: use the same image for revscoring models

https://gerrit.wikimedia.org/r/868407

gerritbot added a comment.Dec 15 2022, 2:12 PM

Change 868407 merged by Elukey:

[operations/deployment-charts@master] ml-services: use the same image for revscoring models

https://gerrit.wikimedia.org/r/868407

gerritbot added a comment.Dec 15 2022, 3:55 PM

Change 868433 had a related patch set uploaded (by Ilias Sarantopoulos; author: Ilias Sarantopoulos):

[machinelearning/liftwing/inference-services@main] revscoring: delete individual revscoring images

https://gerrit.wikimedia.org/r/868433

gerritbot added a comment.Dec 15 2022, 4:05 PM

Change 868437 had a related patch set uploaded (by Ilias Sarantopoulos; author: Ilias Sarantopoulos):

[integration/config@master] inference-services: remove old revscoring pipelines

https://gerrit.wikimedia.org/r/868437

gerritbot added a comment.Dec 15 2022, 4:43 PM

Change 868437 merged by jenkins-bot:

[integration/config@master] inference-services: remove old revscoring pipelines

https://gerrit.wikimedia.org/r/868437

Stashbot added a comment.Dec 15 2022, 4:51 PM

Mentioned in SAL (#wikimedia-releng) [2022-12-15T16:51:41Z] <hashar> Reloading Zuul for https://gerrit.wikimedia.org/r/c/integration/config/+/868437/ "inference-services: remove old revscoring pipelines" | T323586

gerritbot added a comment.Dec 16 2022, 9:48 AM

Change 868433 merged by jenkins-bot:

[machinelearning/liftwing/inference-services@main] revscoring: delete individual revscoring images

https://gerrit.wikimedia.org/r/868433

isarantopoulos mentioned this in rMLIS4ae9054e24bd: revscoring: delete individual revscoring images.Dec 16 2022, 9:48 AM
isarantopoulos moved this task from In Progress to Complete Q3 2022/23 on the Machine-Learning-Team board.Dec 16 2022, 2:15 PM
calbon closed this task as Resolved.Jan 24 2023, 3:34 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 24 2023, 4:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits