Page MenuHomePhabricator

Synchronize fasthttp changes from pageviews to unique devics
Closed, ResolvedPublic3 Estimated Story Points

Description

This merge request switched the AQS 2.0 pageviews service to the fasthttp router. The unique devices service was previously switched in this merge request, but did not include all that changes that made it into pageviews.

Notably, unique devices currently includes a hard-coded timeout value, which we made be a config variable in pageviews. Sorry, I should have caught that in code review on the previous merge.

Please port any relevant improvements, including the config variable, from pageviews to unique devices, so that the two services match.

Details

Due Date
Dec 5 2022, 6:00 AM

Event Timeline

BPirkle moved this task from Incoming to Sprint 01 on the API Platform board.
BPirkle edited projects, added API Platform (Sprint 01); removed API Platform.
SGupta-WMF changed the task status from Open to In Progress.Nov 23 2022, 10:20 AM
JArguello-WMF set the point value for this task to 3.Nov 29 2022, 8:02 PM

Change 862254 had a related patch set uploaded (by Atieno; author: Sg912):

[generated-data-platform/aqs/device_analytics@main] T323643 : Context leak and problem code

https://gerrit.wikimedia.org/r/862254

Test Status: QA PASS

no breaking changes to existing code

Change 862254 merged by BPirkle:

[generated-data-platform/aqs/device_analytics@main] T323643 : Context leak and problem code

https://gerrit.wikimedia.org/r/862254