Page MenuHomePhabricator
Create Task
Maniphest T324687

PHP layer thinks Typed List with expanded type as its first element is not well-formed
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Steps to reproduce:

  1. Go to Z801, details tab.

Observed behavior:

  • Final test fails - PHP layer throws error when calling ZObjectFactory::create on response from Orchestrator. This is because T324661 means the Orchestrator is returning the list with expanded Z6 as first element.

Expected behavior (Acceptance criteria):

  • PHP layer should accept this as well-formed.

Completion checklist

Details

SubjectRepoBranchLines +/-
ZObjectFactory: Allow inline ZTypes in Benjamin arraysmediawiki/extensions/WikiLambdamaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

EWright created this task.Dec 7 2022, 4:26 PM
EWright mentioned this in T324661: Orchestrator returning Typed List with fully expanded type as its first element.
gerritbot added a comment.Dec 7 2022, 4:42 PM

Change 865694 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZObjectFactory: Allow inline ZTypes in Benjamin arrays

https://gerrit.wikimedia.org/r/865694

gerritbot added a project: Patch-For-Review.Dec 7 2022, 4:42 PM
Jdforrester-WMF claimed this task.Dec 7 2022, 4:42 PM
gerritbot added a comment.Dec 7 2022, 4:56 PM

Change 865694 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjectFactory: Allow inline ZTypes in Benjamin arrays

https://gerrit.wikimedia.org/r/865694

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 7 2022, 5:01 PM
EWright mentioned this in T314621: ZObjectFactory::create() throwing more exceptions when called from ApiPerformTest.php.Dec 7 2022, 5:22 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 7 2022, 5:30 PM
Jdforrester-WMF closed this task as Resolved.Dec 7 2022, 11:25 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL